Skip to content

Commit 7fb9c6c

Browse files
committed
support for scala2.13.
Signed-off-by: ta.tanaka <takayahilton@gmail.com>
1 parent 02bac46 commit 7fb9c6c

File tree

15 files changed

+44
-179
lines changed

15 files changed

+44
-179
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,4 @@ project/target/
88
*~
99
.idea
1010
.idea_modules
11+
*.iml

.travis.yml

+10-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
language: scala
22
scala:
3-
- 2.11.8
4-
- 2.12.1
3+
- 2.11.12
4+
- 2.12.8
5+
- 2.13.0
56

67
sudo: false
78

@@ -10,7 +11,13 @@ script: sbt ++$TRAVIS_SCALA_VERSION test
1011
before_install:
1112
- rvm install 2.2.0
1213
- rvm use 2.2.0
13-
- gem install fluentd -v 0.14.11
14+
- gem install fluentd -v 1.6.2
1415

1516
jdk:
1617
- oraclejdk8
18+
19+
cache:
20+
directories:
21+
- $HOME/.ivy2/cache
22+
- $HOME/.sbt
23+
- $HOME/.coursier

build.sbt

+6-6
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,16 @@ organization := "org.fluentd"
44
name := "fluent-logger-scala"
55

66
publishMavenStyle := true
7-
scalaVersion := "2.12.1"
8-
crossScalaVersions := Seq("2.11.8", scalaVersion.value)
7+
scalaVersion := "2.12.8"
8+
crossScalaVersions := Seq("2.11.12", scalaVersion.value, "2.13.0")
99
scalacOptions ++= Seq("-deprecation", "-feature", "-language:implicitConversions")
1010
logBuffered in Test := false
1111
libraryDependencies ++= Seq(
12-
"org.fluentd" % "fluent-logger" % "0.3.2",
13-
"org.json4s" %% "json4s-native" % "3.5.0",
12+
"org.fluentd" % "fluent-logger" % "0.3.4",
13+
"org.json4s" %% "json4s-native" % "3.6.7",
1414
"junit" % "junit" % "4.12" % Test,
15-
"org.xerial" %% "fluentd-standalone" % "0.14.11" % Test,
16-
"org.scalatest" %% "scalatest" % "3.0.1" % Test
15+
"org.xerial" %% "fluentd-standalone" % "1.6.2" % Test,
16+
"org.scalatest" %% "scalatest" % "3.0.8" % Test
1717
)
1818

1919
// Release settings

project/build.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
sbt.version=0.13.13
1+
sbt.version=1.2.8

project/plugin.sbt

+7-5
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1-
addSbtPlugin("com.github.gseitz" % "sbt-release" % "1.0.3")
2-
addSbtPlugin("org.xerial.sbt" % "sbt-sonatype" % "1.1")
3-
addSbtPlugin("com.jsuereth" % "sbt-pgp" % "1.0.0")
4-
addSbtPlugin("io.get-coursier" % "sbt-coursier" % "1.0.0-M15")
5-
addSbtPlugin("net.virtual-void" % "sbt-dependency-graph" % "0.7.5")
1+
addSbtCoursier
2+
3+
addSbtPlugin("com.github.gseitz" % "sbt-release" % "1.0.11")
4+
addSbtPlugin("org.xerial.sbt" % "sbt-sonatype" % "2.3")
5+
addSbtPlugin("com.jsuereth" % "sbt-pgp" % "1.1.2")
6+
addSbtPlugin("net.virtual-void" % "sbt-dependency-graph" % "0.10.0-RC1")
7+
addSbtPlugin("com.timushev.sbt" % "sbt-updates" % "0.4.2")
68

79
scalacOptions ++= Seq("-deprecation", "-feature")

project/project/plugin.sbt

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
addSbtPlugin("io.get-coursier" % "sbt-coursier" % "2.0.0-RC2")

src/main/scala/org/fluentd/logger/scala/FluentLogger.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ package org.fluentd.logger.scala
33
import org.fluentd.logger.scala.sender.Sender
44
import scala.collection.Map
55

6-
case class FluentLogger(tag :String, sender: Sender) {
6+
case class FluentLogger(tag: String, sender: Sender) {
77

88
def log(label: String, key: String, value: Any): Boolean = {
99
log(label, key, value, 0)
@@ -41,7 +41,7 @@ case class FluentLogger(tag :String, sender: Sender) {
4141

4242
def getName: String = sender.getName()
4343

44-
override def toString: String = sender.toString()
44+
override def toString: String = sender.toString
4545

4646
override def finalize(): Unit = sender.close()
4747

src/main/scala/org/fluentd/logger/scala/FluentLoggerFactory.scala

+1-7
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ object FluentLoggerFactory {
2525
val senderPropertyName = JavaConstants.FLUENT_SENDER_CLASS
2626
val scalaSenderName = "ScalaRawSocketSender"
2727
val senderClassName = System.getProperty(senderPropertyName, scalaSenderName)
28-
val factory = new FluentLoggerFactory()
2928
val loggers: WeakHashMap[String, FluentLogger] = new WeakHashMap
3029

3130
def getLogger(tag: String): FluentLogger = {
@@ -39,7 +38,7 @@ object FluentLoggerFactory {
3938
def getLogger(tag: String, host: String, port: Int,
4039
timeout: Int, bufferCapacity: Int): FluentLogger = {
4140
val sender = new ScalaRawSocketSender(host, port, timeout, bufferCapacity)
42-
val logger = new FluentLogger(tag, sender)
41+
val logger = FluentLogger(tag, sender)
4342
loggers.put(tag, logger)
4443
logger
4544
}
@@ -55,9 +54,4 @@ object FluentLoggerFactory {
5554
logger.close()
5655
}
5756
}
58-
59-
}
60-
61-
class FluentLoggerFactory {
62-
6357
}

src/main/scala/org/fluentd/logger/scala/sender/EventSerializer.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ object EventSerializer extends Serializer[Event] {
1515
def deserialize(implicit format: Formats): PartialFunction[(TypeInfo, JValue), Event] = {
1616
case (TypeInfo(EventClass, _), json) => json match {
1717
case JArray(JString(tag) :: JInt(time) :: JObject(obj) :: Nil) =>
18-
new Event(tag, time.toLong, null)
18+
Event(tag, time.toLong, null)
1919
case JNothing =>
20-
new Event(null, 0, null)
20+
Event(null, 0, null)
2121
case x => throw new MappingException(s"Can't convert $x to Event")
2222
}
2323
}

src/main/scala/org/fluentd/logger/scala/sender/MapSerializer.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ object MapSerializer extends Serializer[Map[String, Any]] {
1616
},
1717
Extraction.decompose(
1818
v match {
19-
case vs: MutableMap[_,_] => vs.toMap
19+
case vs: MutableMap[_, _] => vs.toMap
2020
case _ => v
2121
}
2222
)

src/main/scala/org/fluentd/logger/scala/sender/ScalaRawSocketSender.scala

+9-9
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,20 @@ import org.json4s._
88
import org.json4s.native.Serialization
99
import scala.collection.Map
1010

11-
class ScalaRawSocketSender(h:String, p:Int, to:Int, bufCap:Int)
11+
class ScalaRawSocketSender(h: String, p: Int, to: Int, bufCap: Int)
1212
extends Sender {
13-
implicit val formats = DefaultFormats + EventSerializer + MapSerializer
13+
implicit val formats: Formats = DefaultFormats + EventSerializer + MapSerializer
1414
val LOG = java.util.logging.Logger.getLogger("ScalaRawSocketSender")
1515
val host = h
1616
val port = p
17-
val bufferCapacity= bufCap
17+
val bufferCapacity = bufCap
1818
val timeout = to
1919
val name = "%s_%d_%d_%d".format(host, port, timeout, bufferCapacity)
2020
val pendings = ByteBuffer.allocate(bufferCapacity)
2121
val server = new InetSocketAddress(host, port)
2222
val reconnector = new ExponentialDelayReconnector()
23-
var socket:Socket = null
24-
var out:BufferedOutputStream = null
23+
var socket: Socket = null
24+
var out: BufferedOutputStream = null
2525
open()
2626

2727
def this(host:String, port:Int) {
@@ -96,7 +96,7 @@ class ScalaRawSocketSender(h:String, p:Int, to:Int, bufCap:Int)
9696
}
9797

9898
def emit(tag: String, timestamp: Long, data: Map[String, Any]): Boolean = {
99-
emit(new Event(tag, timestamp, data))
99+
emit(Event(tag, timestamp, data))
100100
}
101101

102102
def emit(event: Event): Boolean = {
@@ -107,7 +107,7 @@ class ScalaRawSocketSender(h:String, p:Int, to:Int, bufCap:Int)
107107
try {
108108
// serialize tag, timestamp and data
109109
val json = Serialization.write(event)
110-
return send(json.getBytes("UTF-8"))
110+
send(json.getBytes("UTF-8"))
111111
} catch {
112112
case e: IOException =>
113113
LOG.severe(s"Cannot serialize event: $event")
@@ -155,14 +155,14 @@ class ScalaRawSocketSender(h:String, p:Int, to:Int, bufCap:Int)
155155
clearBuffer()
156156
} catch {
157157
case e: IOException =>
158-
LOG.throwing(this.getClass().getName(), "flush", e)
158+
LOG.throwing(this.getClass.getName, "flush", e)
159159
reconnector.addErrorHistory(System.currentTimeMillis())
160160
}
161161
}
162162

163163
def getName(): String = name
164164

165-
override def toString(): String = {
165+
override def toString: String = {
166166
getName()
167167
}
168168
}

src/main/scala/org/fluentd/logger/scala/sender/Sender.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ trait Sender {
77

88
def emit(tag: String, timestamp: Long, data: Map[String, Any]): Boolean
99

10-
def flush()
10+
def flush(): Unit
1111

1212
def getBuffer(): Array[Byte]
1313

14-
def close()
14+
def close(): Unit
1515

1616
def getName(): String
1717
}

src/test/java/org/fluentd/logger/util/MockFluentd.java

-132
This file was deleted.

src/test/scala/org/fluentd/logger/scala/FluentLoggerSuite.scala

+1-2
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import org.junit.runner.RunWith
2222
import org.json4s.NoTypeHints
2323
import org.json4s.native.Serialization
2424
import org.scalatest.{BeforeAndAfterAll, Tag, FunSuite}
25-
import org.scalatest.junit.JUnitRunner
25+
import org.scalatestplus.junit.JUnitRunner
2626
import scala.collection.mutable.HashMap
2727
import xerial.fluentd.FluentdStandalone
2828

@@ -36,7 +36,6 @@ class FluentLoggerSuite extends FunSuite with BeforeAndAfterAll {
3636
override def beforeAll(): Unit = {
3737
// Start local fluentd server
3838
fluentd = Some(FluentdStandalone.start())
39-
val port = fluentd.get.port
4039
logger = fluentd.map(fd => FluentLoggerFactory.getLogger("debug", "localhost", fd.port)).getOrElse {
4140
fail("Failed to start fluentd")
4241
}

src/test/scala/org/fluentd/logger/scala/util/Verifier.scala

-7
This file was deleted.

0 commit comments

Comments
 (0)