Alert NoOutputBytesProcessed should combine outputs #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1 similar comment
|
edsiper
added
the
waiting-for-user
|
Hi, @MPV would you mind reviewing the last comment? |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
MPV
force-pushed
the
patch-1
branch
2 times, most recently
from
e800815 to
bd67bc2
Compare
We were seeing issues where we got alerted due to some outputs not sending data for more than 15 minutes. For example, this is expected from journald logs on worker nodes in a cluster, thus this adjustment to the alert. We now aggregate output per pod and alert if no bytes are sent for 15 minutes. Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>
|
@lecaros could you review this again? commit has been signed now. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
@edsiper, interested in this change? Happy to close it if not useful as-is.😊 |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing issues where we got alerted due to some outputs not sending data for more than 15 minutes.
For example, this is expected from journald logs on worker nodes in a cluster, thus this adjustment to the alert.
We now aggregate output per pod and alert if no bytes are sent for 15 minutes.