diff --git a/docs/developer-notes.md b/docs/developer-notes.md new file mode 100644 index 00000000..fea8dde7 --- /dev/null +++ b/docs/developer-notes.md @@ -0,0 +1,5 @@ +In marine-rs-sdk we use the following conventions for PR reviewing: +- **Concept ACK** - agree with the idea and overall concept, but haven't reviewed the code changes or tested them, +- **utACK (untested ACK)** - reviewed and agree with the code changes but haven't actually tested them, +- **Tested ACK** - reviewed the code changes and have verified the functionality or a bug fix, +- **NACK** - disagree with the code changes/concept, should be accompanied by an explanation.