-
Notifications
You must be signed in to change notification settings - Fork 10
Add deken upload #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add deken upload #111
Conversation
|
This PR looks good, but I think we can just fold it into the actions repository and call it in https://github.com/flucoma/actions So what I imagine is a new folder What do you think @ben-wes? |
|
... and I am still waiting for the puredata.org account creation for us to be able to upload. |
Exactly. Have a go and if you get stuck at any point I'm more than happy to help. Just @ me. Where it might get difficult is testing it works as GitHub actions is a total pita for this. What I'd suggest is making it so that the release branch also captures branches called deken-* so we can spin off branches to push and test. |
|
@jamesb93 this is now updated and should ideally work combined with flucoma/actions#7 and a i'm not sure it's acceptable that i now updated the for testing, we should now also get a deken release from a branch that is named EDIT: some additional information for the deken tests ...
|
|
also I have received the login for flucoma - i can put the deets in a secret if @jamesb93 tells me how 😆 |
… on deken install
|
squashed the changes to make the PR a bit cleaner. |
this PR was motivated by some users asking for a simple FluCoMa installation via deken.
it adds a new
deken-uploadworkflow which is triggered after a successful release.a
FluidCorpusManipulationdeken package is created and its name and content is printed in the workflow summary and uploaded as an artifact (see https://github.com/ben-wes/flucoma-pd/actions/runs/18846787301 as an example).the actual upload to deken is only triggered if the release was made on the
productionbranch. the upload requiresDEKEN_USERNAMEandDEKEN_PASSWORDsecrets.README.deken.pdis a new patch that automatically opens after the installation. it provides direct access to the preferences for adding path and library - and also a button for adding the flucoma folder to Pd's search path. unfortunately, this doesn't seem possible for thefluid_libmanipulationlibrary, so it needs to be added by the user.it also links to the object overview and displays the reference launcher:
feedback welcome - the workflow might not be the most elegant. and obviously, the patch is also mainly a suggestion (the use of the
add-to-pathmessage is slightly hacky, but should work well afaict).... thank you for your work and for sharing FluCoMa with everyone!