Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added microtime for more unique ness #180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

knvpk
Copy link

@knvpk knvpk commented Jun 9, 2016

related to issue #179

@AidasK
Copy link
Member

AidasK commented Jun 9, 2016

How is it possible, for a file, to have micro_time attribute?

I think you can make use of this:
https://developer.mozilla.org/en-US/docs/Web/API/File/lastModifiedDate

@knvpk
Copy link
Author

knvpk commented Jun 9, 2016

What you have linked is deprecated and there is also chances of same name,same size and same lastModifiedTime,So im attaching a new one. File doesn't have any micro_time key, but im attaching one if there is no one.

@drzraf
Copy link
Collaborator

drzraf commented Jan 11, 2021

relativePath += "-" + (lastModified || Date.now());
Sounds reasonable isn't?

@drzraf
Copy link
Collaborator

drzraf commented Sep 15, 2021

@AidasK : What do you think?

@AidasK
Copy link
Member

AidasK commented Sep 16, 2021

Why do we need that generateUniqueIdentifier would modify our file instance?

Also more uniqueness means file might not get resumed, if this is the intention, I think it can be solved differently.

Also, there is a new property which is not deprecated https://developer.mozilla.org/en-US/docs/Web/API/File/lastModified

@drzraf
Copy link
Collaborator

drzraf commented Sep 16, 2021

Using lastModified is what I suggested to add more uniqueness.
(Note that if lastModified changed, we may actually prefer not to resume such a file)
Does it mean you're rather favorable to a PR going into that direction? (I could soon provide one)

@AidasK
Copy link
Member

AidasK commented Sep 17, 2021

Yes, let’s use lastModified for more uniqueness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants