Support of isMarkerVisible at ExclusiveGateway according to BPMN 2.0 #3393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
domi-87
commented
Jul 15, 2022
domi-87
commented
- Unit tests: NA
- Documentation: NA
filiphr
requested changes
Dec 20, 2022
There was a problem hiding this comment.
Thanks for this PR @domi-87.
Since Flowable is not using this, but even if we decide to use it the default value currently is true, i.e. the marker is shown. I would suggest that we also reflect this in the Java model and only export it to the XML when the value is false.
In addition to that, can you please add a test case for this?
|
Hi @filiphr Thanks for your feedback. Can you give me a hint on how/where to best locate the test? Or rather if I can use a test as a model.... |
|
Have a look at the |
|
@filiphr What do you think about my last commit. Adjusted the default behavior accordingly and added a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.