-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sokol_gfx.h resource bindings cleanup (issue #1037) #1111
Draft
floooh
wants to merge
59
commits into
master
Choose a base branch
from
issue1037_bindings_cleanup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8,637
−5,776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a null bindgroup is allowed now
… Dawn webgpu.h differences
…t empty bindgroups
… order, not in bindgroup entry order)
floooh
force-pushed
the
issue1037_bindings_cleanup
branch
from
October 14, 2024 15:35
836e82e
to
cfad5c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #1037
TODO:
metallic_params => binding=2
andlight_param => binding=1
correctmetallic_params => binding=1
andlight_param => binding=2
incorrectconsider removing the trailingno, it's good like that_n
from the new backend bind slots?auto-binding(manual@bindslot
definitions required now)ATTR_*
defines per program:ATTR_[prg]_[name]
renameSLOT_*
defines toUB_[prg]_[name]
,IMG_[prg]_[name]
,SMP_[prg]_[name]
andSBUF_[prg]_[name]
get rid of the 'merged reflection info', with the above per-program slot definitions that's no longer neededlayout(binding=N)
NOTE: in order to allow combining 'random' vertex and fragment shaders in sokol-shdc, shader dialects with common bind space across stages (e.g. GLSL ssbos and WebGPU), sokol-shdc needs to assign vertex- and fragment-stage bindings to separate ranges. This may require some changes in the GL and WebGPU backends for the size of binding caches.
Q:
glsl_location_n
instead ofglsl_name
binding for uniforms? This would not be supported in GL 4.1 or WebGL2.wgsl_location_n
and at least a couple of fixes where loops over the vertex attributes stopped on the first empty attribute => in sokol-shdc this is sort-of already supported becauselayout(location = n)
works for vertex attributes