block out workspace ui and interactions, add examples #1666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| <html> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta |
Check warning
Code scanning / Electronegativity
One or more CSP directives detected are vulnerable
| <html> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta |
Check warning
Code scanning / Electronegativity
One or more CSP directives detected are vulnerable
mholtzman
reviewed
Sep 21, 2023
|
|
||
| const ribbon = useStore('windows.workspaces', window.frameId, 'ribbon') || {} | ||
|
|
||
| console.log('ribbon.expanded', ribbon.expanded) |
| } | ||
|
|
||
| const setShow = () => { | ||
| console.log('setShow: ') |
|
|
||
| const platform = useStore('platform') | ||
|
|
||
| console.log(' hideDockWrap', hideDockWrap) |
| }) | ||
| if (!viewInstance) return | ||
|
|
||
| // const animationSpeed = 8 // Pixels per frame |
There was a problem hiding this comment.
can we remove some of these comments or is it likely we'll need them in the near future?
There was a problem hiding this comment.
yeah all the comments i left in need to be uncommented
|
|
||
| // viewInstance.webContents.openDevTools({ mode: 'detach' }) | ||
|
|
||
| const testDapps = [ |
There was a problem hiding this comment.
just confirming we want to keep these in here for now
There was a problem hiding this comment.
i added these in today before merging to make testing prototype possible, when opening a view it will choose one randomly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.