Add http method to output #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,18 +22,20 @@ function time(start) { | |||
|
|
|||
| function defaultHandler(request, options, cb) { | |||
| var url = (typeof options === 'string' ? urlParse(options) : options).href; | |||
| var method = '[' + options.method + ']'; | |||
There was a problem hiding this comment.
options.method can be undefined quite often
There was a problem hiding this comment.
Ah ok. Are you fine with the idea in general? I would add fallback to get then
There was a problem hiding this comment.
Just do options.method || 'GET'. That is accurate according to the API.
sdepold
force-pushed
the
feature/http-method
branch
from
dbb2464 to
1250e01
Compare
|
Sweet, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great project :)
This PR prepends the http method to the requested URL.