Skip to content

Conversation

@n0nag0n
Copy link
Collaborator

@n0nag0n n0nag0n commented Jun 17, 2025

Related to flightphp/docs#28 with using "data" as a key in the array.

@n0nag0n n0nag0n requested a review from Copilot June 17, 2025 13:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the issue raised in #28 by allowing the use of "data" as a key for passing template variables. Key changes include:

  • Updating tests/server/template.phtml to check for and render the "data" variable.
  • Adding a new route in tests/server/index.php to handle a "data" based template.
  • Renaming the render() method parameter and updating docblocks in flight/template/View.php to improve clarity.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/server/template.phtml Added conditional branch for "$data" handling
tests/server/index.php Introduces a new route to render the template with "data"
tests/server/LayoutMiddleware.php Updated navigation to include the new template route
flight/template/View.php Renamed parameter/documentation from "$data" to "$templateData"
Comments suppressed due to low confidence (1)

flight/template/View.php:110

  • [nitpick] Consider aligning the variable names used in the render() method with the keys provided by controllers (e.g., using 'templateData' versus 'data') to reduce potential confusion.
    public function render(string $file, ?array $templateData = null): void

@n0nag0n n0nag0n merged commit 5df2800 into master Jun 17, 2025
6 checks passed
@n0nag0n n0nag0n deleted the bad-data-var-in-view branch June 17, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants