Skip to content

fix: SafeArea object has no attribute _SafeArea__minimum #4500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions sdk/python/packages/flet/src/flet/core/circle_avatar.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ def main(page):
def __init__(
self,
content: Optional[Control] = None,
foreground_image_url: Optional[str] = None,
background_image_url: Optional[str] = None,
foreground_image_src: Optional[str] = None,
background_image_src: Optional[str] = None,
color: Optional[ColorValue] = None,
Expand Down Expand Up @@ -152,8 +150,6 @@ def __init__(
data=data,
)

self.foreground_image_url = foreground_image_url
self.background_image_url = background_image_url
self.foreground_image_src = foreground_image_src
self.background_image_src = background_image_src
self.radius = radius
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,6 @@ def __init__(
style: Optional[ButtonStyle] = None,
popup_animation_style: Optional[AnimationStyle] = None,
size_constraints: Optional[BoxConstraints] = None,
on_cancelled: OptionalControlEventCallable = None,
on_open: OptionalControlEventCallable = None,
on_cancel: OptionalControlEventCallable = None,
on_select: OptionalControlEventCallable = None,
Expand Down
3 changes: 0 additions & 3 deletions sdk/python/packages/flet/src/flet/core/safe_area.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ def __init__(
right: Optional[bool] = None,
bottom: Optional[bool] = None,
maintain_bottom_view_padding: Optional[bool] = None,
minimum: PaddingValue = None,
minimum_padding: PaddingValue = None,
#
# ConstrainedControl
Expand Down Expand Up @@ -99,7 +98,6 @@ def __init__(
self.right = right
self.bottom = bottom
self.maintain_bottom_view_padding = maintain_bottom_view_padding
self.minimum = minimum
self.minimum_padding = minimum_padding

def _get_control_name(self):
Expand All @@ -108,7 +106,6 @@ def _get_control_name(self):
def before_update(self):
super().before_update()
assert self.__content.visible, "content must be visible"
self._set_attr_json("minimum", self.__minimum)
self._set_attr_json("minimumPadding", self.__minimum_padding)

def _get_children(self):
Expand Down