Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capturing web client info: IP and user agent #1302

Merged
merged 1 commit into from
Apr 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions sdk/python/packages/flet-core/src/flet_core/page.py
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,8 @@ def __get_page_detail_commands(self):
Command(0, "get", ["page", "windowHeight"]),
Command(0, "get", ["page", "windowTop"]),
Command(0, "get", ["page", "windowLeft"]),
Command(0, "get", ["page", "clientIP"]),
Command(0, "get", ["page", "clientUserAgent"]),
]

def __set_page_details(self, values):
Expand All @@ -242,6 +244,8 @@ def __set_page_details(self, values):
self._set_attr("windowHeight", values[7], False)
self._set_attr("windowTop", values[8], False)
self._set_attr("windowLeft", values[9], False)
self._set_attr("clientIP", values[10], False)
self._set_attr("clientUserAgent", values[11], False)

def update(self, *controls):
with self.__lock:
Expand Down Expand Up @@ -1010,6 +1014,16 @@ def web(self) -> bool:
def platform(self):
return self._get_attr("platform")

# client_ip
@property
def client_ip(self):
return self._get_attr("clientIP")

# client_user_agent
@property
def client_user_agent(self):
return self._get_attr("clientUserAgent")

# design
@property
def design(self) -> Optional[PageDesignLanguage]:
Expand Down
8 changes: 5 additions & 3 deletions server/page/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ type Client struct {
role ClientRole
conn connection.Conn
clientIP string
clientUserAgent string
subscription chan []byte
sessions map[string]*model.Session
pages map[string]*model.Page
Expand All @@ -49,7 +50,7 @@ func autoID() string {
return uuid.New().String()
}

func NewClient(conn connection.Conn, clientIP string) *Client {
func NewClient(conn connection.Conn, clientIP string, clientUserAgent string) *Client {

ip := clientIP
if ip == "::1" {
Expand All @@ -60,6 +61,7 @@ func NewClient(conn connection.Conn, clientIP string) *Client {
id: autoID(),
conn: conn,
clientIP: ip,
clientUserAgent: clientUserAgent,
sessions: make(map[string]*model.Session),
pages: make(map[string]*model.Page),
pageNames: make(map[string]bool),
Expand Down Expand Up @@ -269,7 +271,7 @@ func (c *Client) registerWebClientCore(request *RegisterWebClientRequestPayload)
return
}

session = newSession(page, uuid.New().String(), c.clientIP,
session = newSession(page, uuid.New().String(), c.clientIP, c.clientUserAgent,
request.PageRoute, request.PageWidth, request.PageHeight,
request.WindowWidth, request.WindowHeight, request.WindowTop, request.WindowLeft,
request.IsPWA, request.IsWeb, request.Platform)
Expand Down Expand Up @@ -425,7 +427,7 @@ func (c *Client) registerHostClient(message *Message) {
// retrieve zero session
session := store.GetSession(page, ZeroSession)
if session == nil {
session = newSession(page, ZeroSession, c.clientIP, "", "", "", "", "", "", "", "", "", "")
session = newSession(page, ZeroSession, c.clientIP, c.clientUserAgent, "", "", "", "", "", "", "", "", "", "")
} else if !request.Update {
err = cleanPage(session)
if err != nil {
Expand Down
4 changes: 3 additions & 1 deletion server/page/session_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ type addCommandBatchItem struct {
}

// NewSession creates a new instance of Session.
func newSession(page *model.Page, id string, clientIP string,
func newSession(page *model.Page, id string, clientIP string, clientUserAgent string,
pageRoute string, pageWidth string, pageHeight string,
windowWidth string, windowHeight string,
windowTop string, windowLeft string, isPwa string, isWeb string, platform string) *model.Session {
Expand All @@ -70,6 +70,8 @@ func newSession(page *model.Page, id string, clientIP string,
p.SetAttr("pwa", isPwa)
p.SetAttr("web", isWeb)
p.SetAttr("platform", platform)
p.SetAttr("clientIP", clientIP)
p.SetAttr("clientUserAgent", clientUserAgent)
h.addControl(p)

return s
Expand Down
2 changes: 1 addition & 1 deletion server/server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -206,5 +206,5 @@ func websocketHandler(c *gin.Context) {
}

wsc := page_connection.NewWebSocket(conn)
page.NewClient(wsc, c.ClientIP())
page.NewClient(wsc, c.ClientIP(), c.Request.UserAgent())
}