Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include expiration info, drop "personalized", in MFA email #24630

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

iansltx
Copy link
Member

@iansltx iansltx commented Dec 11, 2024

For #22078.

Checklist for submitter

  • Manual QA for all new/changed functionality

@iansltx
Copy link
Member Author

iansltx commented Dec 11, 2024

image

The 15 minute expiration will vary if someone tweaks the constant and recompiles.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.56%. Comparing base (fe3606e) to head (f573b81).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
server/mail/mfa.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24630      +/-   ##
==========================================
+ Coverage   63.51%   63.56%   +0.04%     
==========================================
  Files        1593     1598       +5     
  Lines      151206   151433     +227     
  Branches     3911     3911              
==========================================
+ Hits        96045    96261     +216     
- Misses      47508    47516       +8     
- Partials     7653     7656       +3     
Flag Coverage Δ
backend 64.35% <50.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mostlikelee mostlikelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iansltx iansltx merged commit 0bb7f2e into main Dec 11, 2024
22 checks passed
@iansltx iansltx deleted the mfa-email-fixes branch December 11, 2024 00:58
iansltx added a commit that referenced this pull request Dec 11, 2024
For #22078.

# Checklist for submitter

- [x] Manual QA for all new/changed functionality
iansltx added a commit that referenced this pull request Dec 11, 2024
@jmwatts
Copy link
Member

jmwatts commented Dec 11, 2024

QA Note:

Confirmed in v4.61.0 rc
Screenshot 2024-12-11 at 2.36.51 PM.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants