Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adhere to PSR-7/PSR-17/PSR-18 #2

Open
flavioheleno opened this issue Sep 12, 2023 · 0 comments
Open

Adhere to PSR-7/PSR-17/PSR-18 #2

flavioheleno opened this issue Sep 12, 2023 · 0 comments

Comments

@flavioheleno
Copy link
Owner

The code right now uses some ad-hoc curl requests for both domain and certificate checks, this obviously is sub-optimal as it will be hard to write tests to it.

Another point is that some of the dependencies also ship their own HTTP Client implementation as part of their code, which means that we have code duplication here and there.

Ideally the best solution would be to adhere to HTTP related PSRs (PSR-7/PSR-17/PSR-18) and try to contribute back to the dependencies as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant