Unused options in GlobalShortcuts::BindShortcuts impl

[dcz-self]

Operating System

n/a

XDG Desktop Portal version

Git

XDG Desktop Portal version (Other)

No response

Desktop Environment

Other

Desktop Environment (Other)

No response

Expected Behavior

The spec doesn't have unexplained or unneeded parts.

Current Behavior

The non-impl side of BindShortcuts takes an option useful for generating the handle. The impl-side call receives a fully-formed handle, so there's no option necessary. Still, there's the "option" argument in the docs, which is completely lacking any description whatsoever.

The actual code for handling this in xdg-desktop-portal silently drops the options on the floor.

The ListShortcuts call doesn't have one, so it seems unnecessary and unnecessarily confusing.

Steps to Reproduce

1. Go to org-freedesktop-impl-portal-globalshortcuts-bindshortcuts
2. Notice "options"
3. Notice lack of description.
   ...

Anything else we should know?

No response

[matthiasclasen]

Yeah, its unused, we should document it as such. Removing it from the xml now would be needlessly disruptive for existing implementations. Could be done as cleanup if we ever rev the interface, though.