iwyu: tidy #includes

flatcap · Apr 12, 2021 · bd81c60 · bd81c60
1 parent a89521f
commit bd81c60
Show file tree

Hide file tree

Showing 25 changed files with 17 additions and 29 deletions.
diff --git a/alias/dlgalias.c b/alias/dlgalias.c
@@ -45,7 +45,6 @@
 #include "format_flags.h"
 #include "gui.h"
 #include "keymap.h"
-#include "mutt_globals.h"
 #include "mutt_menu.h"
 #include "muttlib.h"
 #include "opcodes.h"

diff --git a/alternates.c b/alternates.c
@@ -30,21 +30,16 @@
 #include <stdbool.h>
 #include <stdint.h>
 #include <stdio.h>
-#include <string.h>
 #include "mutt/lib.h"
-#include "config/lib.h"
+#include "address/lib.h"
 #include "email/lib.h"
 #include "core/lib.h"
-#include "gui/lib.h"
 #include "mutt.h"
 #include "alternates.h"
-#include "ncrypt/lib.h"
 #include "attachments.h"
 #include "command_parse.h"
 #include "init.h"
 #include "mutt_commands.h"
-#include "mutt_globals.h"
-#include "mx.h"
 
 struct RegexList Alternates = STAILQ_HEAD_INITIALIZER(Alternates); ///< List of regexes to match the user's alternate email addresses
 struct RegexList UnAlternates = STAILQ_HEAD_INITIALIZER(UnAlternates); ///< List of regexes to blacklist false matches in Alternates

diff --git a/alternates.h b/alternates.h
@@ -27,6 +27,9 @@
 #include <stdint.h>
 #include "mutt_commands.h"
 
+struct Buffer;
+struct Mailbox;
+
 /**
  * enum NotifyAlternates - Alternates command notification types
  */

diff --git a/attachments.c b/attachments.c
@@ -41,7 +41,6 @@
 #include "ncrypt/lib.h"
 #include "init.h"
 #include "mutt_commands.h"
-#include "mutt_globals.h"
 #include "mx.h"
 
 /**

diff --git a/commands.c b/commands.c
@@ -62,7 +62,6 @@
 #include "mutt_globals.h"
 #include "mutt_logging.h"
 #include "mutt_mailbox.h"
-#include "mutt_menu.h"
 #include "muttlib.h"
 #include "mx.h"
 #include "options.h"

diff --git a/commands.h b/commands.h
@@ -25,7 +25,6 @@
 
 #include <stdbool.h>
 #include <stdio.h>
-#include "mutt_menu.h"
 
 struct Body;
 struct Email;

diff --git a/gui/curs_lib.h b/gui/curs_lib.h
@@ -29,10 +29,10 @@
 #include "mutt.h"
 #include "browser.h"
 #include "keymap.h"
-#include "pager/lib.h"
 
 struct Buffer;
 struct Mailbox;
+struct PagerView;
 
 extern int MuttGetchTimeout; ///< Timeout in ms for mutt_getch()
 

diff --git a/gui/dialog.c b/gui/dialog.c
@@ -34,6 +34,7 @@
 #include "core/lib.h"
 #include "debug/lib.h"
 #include "lib.h"
+#include "keymap.h"
 #include "mutt_menu.h"
 
 /**

diff --git a/init.c b/init.c
@@ -29,7 +29,6 @@
 
 #include "config.h"
 #include <ctype.h>
-#include <inttypes.h>
 #include <pwd.h>
 #include <stdbool.h>
 #include <stdio.h>
@@ -59,7 +58,6 @@
 #ifdef USE_LUA
 #include "mutt_lua.h"
 #endif
-#include "attachments.h"
 #include "mutt_menu.h"
 #include "muttlib.h"
 #include "myvar.h"

diff --git a/main.c b/main.c
@@ -71,7 +71,6 @@
 #include "mutt_history.h"
 #include "mutt_logging.h"
 #include "mutt_mailbox.h"
-#include "mutt_menu.h"
 #include "muttlib.h"
 #include "mx.h"
 #include "myvar.h"

diff --git a/mutt_attach.c b/mutt_attach.c
@@ -45,7 +45,6 @@
 #include "ncrypt/lib.h"
 #include "pager/lib.h"
 #include "send/lib.h"
-#include "context.h"
 #include "copy.h"
 #include "handler.h"
 #include "mailcap.h"

diff --git a/mx.c b/mx.c
@@ -60,7 +60,6 @@
 #include "opcodes.h"
 #include "options.h"
 #include "protos.h"
-#include "sort.h"
 #ifdef USE_COMP_MBOX
 #include "compmbox/lib.h"
 #endif

diff --git a/ncrypt/crypt.c b/ncrypt/crypt.c
@@ -49,11 +49,9 @@
 #include "lib.h"
 #include "send/lib.h"
 #include "attachments.h"
-#include "context.h"
 #include "copy.h"
 #include "cryptglue.h"
 #include "handler.h"
-#include "mutt_globals.h"
 #include "muttlib.h"
 #include "options.h"
 #ifdef USE_AUTOCRYPT

diff --git a/ncrypt/cryptglue.c b/ncrypt/cryptglue.c
@@ -62,7 +62,6 @@ struct Envelope;
 
 struct Address;
 struct AddressList;
-struct State;
 
 #ifdef CRYPT_BACKEND_CLASSIC_PGP
 extern struct CryptModuleSpecs CryptModPgpClassic;

diff --git a/ncrypt/pgp.h b/ncrypt/pgp.h
@@ -33,6 +33,7 @@
 struct AddressList;
 struct Body;
 struct Email;
+struct Mailbox;
 struct PgpKeyInfo;
 struct State;
 

diff --git a/notmuch/config.c b/notmuch/config.c
@@ -36,7 +36,7 @@
 
 /**
  * is_valid_notmuch_url - Checks that a URL is in required form.
- * @retval true url in form notmuch://<absolute path>
+ * @retval true url in form notmuch://[absolute path]
  * @retval false url is not in required form.
  */
 static bool is_valid_notmuch_url(const char *url)
@@ -45,14 +45,16 @@ static bool is_valid_notmuch_url(const char *url)
 }
 
 /**
- * nm_default_url_validator - Ensure nm_default_url is of the form notmuch://<absolute path> - Implements ConfigDef::validator()
+ * nm_default_url_validator - Ensure nm_default_url is of the form notmuch://[absolute path] - Implements ConfigDef::validator()
  */
-static int nm_default_url_validator(const struct ConfigSet *cs, const struct ConfigDef *cdef, intptr_t value, struct Buffer *err)
+static int nm_default_url_validator(const struct ConfigSet *cs, const struct ConfigDef *cdef,
+                                    intptr_t value, struct Buffer *err)
 {
   const char *url = (const char *) value;
   if (!is_valid_notmuch_url(url))
   {
-    mutt_buffer_printf(err, _("nm_default_url must be: notmuch://<absolute path> . Current: %s"), url);
+    mutt_buffer_printf(
+        err, _("nm_default_url must be: notmuch://<absolute path> . Current: %s"), url);
     return CSR_ERR_INVALID;
   }
 

diff --git a/protos.h b/protos.h
@@ -33,7 +33,6 @@
 #include "ncrypt/lib.h"
 #include "keymap.h"
 
-struct Context;
 struct Email;
 struct EmailList;
 struct EnterState;

diff --git a/recvattach.c b/recvattach.c
@@ -52,7 +52,6 @@
 #include "keymap.h"
 #include "mailcap.h"
 #include "mutt_attach.h"
-#include "mutt_globals.h"
 #include "mutt_menu.h"
 #include "mutt_thread.h"
 #include "muttlib.h"

diff --git a/recvattach.h b/recvattach.h
@@ -33,6 +33,7 @@
 struct AttachCtx;
 struct Body;
 struct Email;
+struct Mailbox;
 
 void mutt_attach_init(struct AttachCtx *actx);
 void mutt_update_tree(struct AttachCtx *actx);

diff --git a/send/send.h b/send/send.h
@@ -30,7 +30,6 @@
 struct AddressList;
 struct Body;
 struct ConfigSubset;
-struct Context;
 struct Email;
 struct EmailList;
 struct Envelope;

diff --git a/send/sendlib.c b/send/sendlib.c
@@ -49,7 +49,6 @@
 #include "lib.h"
 #include "ncrypt/lib.h"
 #include "attachments.h"
-#include "context.h"
 #include "copy.h"
 #include "handler.h"
 #include "mutt_globals.h"

diff --git a/sort.c b/sort.c
@@ -38,7 +38,6 @@
 #include "core/lib.h"
 #include "alias/lib.h"
 #include "sort.h"
-#include "mutt_globals.h"
 #include "mutt_logging.h"
 #include "mutt_thread.h"
 #include "mx.h"

diff --git a/sort.h b/sort.h
@@ -31,7 +31,6 @@
 #include "options.h" // IWYU pragma: keep
 
 struct Address;
-struct Mailbox;
 struct ThreadsContext;
 
 /**

diff --git a/subjectrx.c b/subjectrx.c
@@ -27,10 +27,12 @@
  */
 
 #include "config.h"
+#include <stddef.h>
 #include <stdint.h>
 #include "mutt/lib.h"
 #include "email/lib.h"
 #include "core/lib.h"
+#include "mutt.h"
 #include "subjectrx.h"
 #include "init.h"
 #include "mutt_commands.h"

diff --git a/subjectrx.h b/subjectrx.h
@@ -28,6 +28,7 @@
 #include "mutt_commands.h"
 
 struct Buffer;
+struct Envelope;
 struct Mailbox;
 
 /**