Adds test coverage

Author: cuducos

poetry.lock

@@ -30,14 +30,15 @@ Flask-WTF = "^0.15.1"
 ipdb = "^0.13.9"
 pytest = "^6.2.4"
 pytest-black = "^0.3.12"
+pytest-cov = "^2.12.1"
 pytest-flake8 = "^1.0.7"
 pytest-flask = "^1.2.0"
 pytest-mock = "^3.6.1"
 tox = "^3.24.2"
 
 [tool.pytest.ini_options]
 flake8-ignore = ["E501", "W503"]
-addopts = "--flake8 --black"
+addopts = "--flake8 --black --cov flask_simplelogin --cov-report term --cov-fail-under=70"
 
 [tool.tox]
 legacy_tox_ini = """

pyproject.toml

@@ -1,7 +1,8 @@
 import pytest
-from flask import Flask, jsonify, render_template
+from flask import Flask, jsonify, render_template, session
 from flask.views import MethodView
 from flask_simplelogin import SimpleLogin, login_required, get_username
+from itsdangerous import URLSafeTimedSerializer
 
 
 @pytest.fixture
@@ -49,3 +50,18 @@ def get(self):
     myapp.add_url_rule("/protected", view_func=ProtectedView.as_view("protected"))
 
     return myapp
+
+
+@pytest.fixture
+def csrf_token_for():
+    """Based on how Flask-WTF generates it on the fly:
+    https://github.com/wtforms/flask-wtf/blob/main/src/flask_wtf/csrf.py#L54-L63
+    """
+
+    def generator(app):
+        serilaizer = URLSafeTimedSerializer(
+            app.config["SECRET_KEY"], salt="wtf-csrf-token"
+        )
+        return serilaizer.dumps(session["csrf_token"])
+
+    return generator

tests/conftest.py

@@ -1,7 +1,6 @@
 from unittest.mock import call
 
-from flask import session, url_for
-from itsdangerous import URLSafeTimedSerializer
+from flask import url_for
 
 from flask_simplelogin import is_logged_in
 
@@ -52,29 +51,37 @@ def test_positive_redirect_to_allowed_host(app):
         assert response.status_code == 200
 
 
-def test_is_logged_in(app, client):
-    def generate_csrf_token_form_value(app):
-        """Based on how Flask-WTF generates it on the fly:
-        https://github.com/wtforms/flask-wtf/blob/main/src/flask_wtf/csrf.py#L54-L63
-        """
-        return URLSafeTimedSerializer(
-            app.config["SECRET_KEY"], salt="wtf-csrf-token"
-        ).dumps(session["csrf_token"])
-
+def test_is_logged_in(app, client, csrf_token_for):
     client.get(url_for("simplelogin.login"))
     assert not is_logged_in()
     response = client.post(
         url_for("simplelogin.login"),
         data={
             "username": "admin",
             "password": "secret",
-            "csrf_token": generate_csrf_token_form_value(app),
+            "csrf_token": csrf_token_for(app),
         },
     )
     assert response.status_code == 302
     assert is_logged_in()
 
 
+def test_logout(app, client, csrf_token_for):
+    client.get(url_for("simplelogin.login"))
+    assert not is_logged_in()
+    client.post(
+        url_for("simplelogin.login"),
+        data={
+            "username": "admin",
+            "password": "secret",
+            "csrf_token": csrf_token_for(app),
+        },
+    )
+    assert is_logged_in()
+    client.get(url_for("simplelogin.logout"))
+    assert not is_logged_in()
+
+
 def test_flash(app, mocker):
     mock_flash = mocker.patch("flask_simplelogin.flash")
     app.extensions["simplelogin"].flash("login_success")