-
Notifications
You must be signed in to change notification settings - Fork 145
ci: build the RISC-V binary #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Part of flashbots#630.
How can I test this? |
if: ${{ github.event.inputs.cross-build-binary == 'true' || github.event_name == 'push'}} # when manually triggered or version tagged | ||
runs-on: warp-ubuntu-2404-x64-32x | ||
container: | ||
image: ubuntu:22.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what this is. The job runs in warp 24.04, right? What's this container for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's understandably confusing. I can add some comments for context to this.
We're running the jobs on Warpbuild runners whose pre-installed software are updated outside of our control by the Warpbuild team. So, to regain control over pre-installed software during the build we run the build inside of a container that runs on the Warpbuild runner.
# defines the runner
runs-on: warp-ubuntu-2404-x64-32x
# the build is run inside of this container which is hosted on the runner
container:
image: ubuntu:22.04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmm, so this will fail in a 22.04 container. I will try to run it in my fork as @metachris said.
pkg-config | ||
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y | ||
|
||
- uses: actions/checkout@v4 # must install git before checkout and set safe.directory after checkout because of container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this I also don't understand, what container?
@come-maiz you can fork the repo and test the release process there! just remove the warpbuild reference, which is just a faster runner but should use the same specs as the default runner. |
Part of #630.
📝 Summary
I've added the cross-build to RISC-V in the github workflow.
💡 Motivation and Context
I want us to make sure that all our sofware can run in RISC-V from the start. That will motivate others to do so, and by the time we have powerful RISC-V machines able to run rbuilder, we will be sooo ready.
✅ I have completed the following steps:
make lint
make test