Skip to content

Commit f25f6ef

Browse files
committed
Adds issue reference to Split-KV disable comment
Documents the GitHub issue tracking the Split-KV bugs that led to temporarily disabling the feature. This provides better context for future developers about why the functionality is disabled and where to find related discussion.
1 parent 0d889b8 commit f25f6ef

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

csrc/flash_api.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,7 @@ std::tuple<at::Tensor, at::Tensor> set_params_splitkv(
256256
}
257257

258258
// Temporarily disable Split-KV, because some bugs are still being fixed.
259+
// See: https://github.com/SmallDoges/flash-dmattn/issues/47
259260
// Regardless of how it is set externally, always set num_splits back to 1.
260261
// This is to avoid the extra memory overhead of Split-KV.
261262
params.num_splits = 1;

0 commit comments

Comments
 (0)