Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "mark all as read" confirmation, but allow the action to be undone #341

Open
tobyzerner opened this issue Mar 20, 2016 · 4 comments
Labels

Comments

@tobyzerner
Copy link

I get really frustrated by the "mark all as read" confirmation - it turns a common task from one click into two.

Let's remove the confirmation, but show an alert when clicked ("All discussions were marked as read") with an undo button which will revert the change. We should also show a tooltip on hover of the button, to make it more obvious what the button does.

@franzliedke
Copy link

How would we implement that undo action, though?

@tobyzerner
Copy link
Author

Before we update the readTime, we can cache its previous value in a variable. Then if the undo button is clicked, we simply make a request to update it with the old value.

@franzliedke
Copy link

Ah, I wasn't aware of the implementation. Ahem.

All good then. If it's that simple, haha... ;)

@askvortsov1
Copy link
Member

Could we keep this entirely to the frontend? Maybe store requests like this in a queue in the frontend app, add an alert with the option to undo. If undone, it's removed from the queue. If not, after 10 seconds or when the page unloads all such requests are sent. If the user tries to navigate away while the request is being sent, show the "are you sure you want to leave" popup, which should provide ample time for the request(s) to complete.

@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants