Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mentions] Scroll so that post is directly above composer when clicking "Reply" #335

Open
tobyzerner opened this issue Mar 29, 2016 · 9 comments
Labels

Comments

@tobyzerner
Copy link

When you click "Reply" on a post that is towards the bottom of the screen, the post composer slides up over the top of it so you have to manually scroll down to see it again. We should do this automatically.

@fernsheldon
Copy link

Hey @tobscure ,

Just to add to this, we've noticed a few issues with regards to the reply composer when viewing on a mobile device :

  • Issue#1 - [iOS specific] When replying to Discussion, by going to the bottom on the list posts and clicking "Write a Reply..." The reply composer opens up, but without the keyboard and cursor. Only after clicking on the text "Write a Reply" or the body of the composer does the cursor appear.
    There is a pull request that solves this issue.
  • Issue#2 - After getting the cursor in the reply composer, on typing the first character, the whole composer shifts to the bottom which looks very jarring. In some cases we've see the whole composer jumps up and down.
  • Issue#3 - Cursor not present on reply composer when the composer to opened after dismissing.
    This is a bit tricky. If you click a reply to a post, then dismiss the composer by clicking the "x". Then when you reopen it, you won't find the cursor - this again leads to issue#2.
  • Issue#4 - on replying to a post that is the last post or towards the bottom - the post composer slides above the top of the screen. This hides the post controls ie close, and the check mark.

@tarunmarkose
Copy link

This is quite a UX issue - sometimes when I type a reply on my mobile, the
composer window keeps jumping up and down with each key press. It becomes
very hard to finish the reply.

On Friday 19 August 2016, Sheldon Fernandes notifications@github.com
wrote:

Hey @tobscure https://github.com/tobscure ,

Just to add to this, we've noticed a few issues with regards to the reply
composer when viewing on a mobile device :

  • Issue#1 - [iOS specific] When replying to Discussion, by going to
    the bottom on the list posts and clicking "Write a Reply..." The reply
    composer opens up, but without the keyboard and cursor. Only after clicking
    on the text "Write a Reply" or the body of the composer does the cursor
    appear. There is a pull request that solves this issue.

    Issue#2 - After getting the cursor in the reply composer, on typing
    the first character, the whole composer shifts to the bottom which looks

    very jarring. In some cases we've see the whole composer jumps up and down.

    Issue#3 - Cursor not present on reply composer when the composer to
    opened after dismissing.

    This is a bit tricky. If you click a reply to a post, then dismiss the
    composer by clicking the "x". Then when you reopen it, you won't find the

    cursor - this again leads to issue#2.

    Issue#4 - on replying to a post that is the last post or towards the
    bottom - the post composer slides above the top of the screen. This hides
    the post controls ie close, and the check mark.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/flarum/core/issues/895#issuecomment-240937273, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHCrLPrjFlyxtDDczmn-3QxP5m-Hb8kgks5qhUpigaJpZM4H7KZJ
.

-Tarun

@tobyzerner
Copy link
Author

@tarunmarkose which browser/version?

@tarunmarkose
Copy link

Safari on iOS 9.3.2...

On Tue, Aug 23, 2016 at 12:54 PM, Toby Zerner notifications@github.com
wrote:

@tarunmarkose https://github.com/tarunmarkose which browser/version?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flarum/core/issues/895#issuecomment-241648887, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHCrLI_yGNB9gmiIHxsdyqPt0proJ6b1ks5qiqAZgaJpZM4H7KZJ
.

@zerosonesfun
Copy link

zerosonesfun commented Oct 5, 2019

This happens in any iOS browser. Safari, Chrome, and Firefox at least. Those are the three iOS browsers I have.

A quick fix, but maybe not the best, I don't know, is to add bottom: 0 !important to a mobile specific CSS rule targeting .Composer.

@laTruffe79
Copy link

I agree, ios users can't reply correctly.

@zerosonesfun
Copy link

To confirm, this works for me and one other person verified. Force bottom: 0; for .Composer, just for mobile widths.

https://discuss.flarum.org/d/6595-scrolltop-in-ios/7

@stale

This comment has been minimized.

@stale stale bot added the stale label Jan 18, 2020
@stale

This comment has been minimized.

@stale stale bot closed this as completed Feb 17, 2020
@franzliedke franzliedke reopened this Mar 13, 2020
@stale stale bot removed the stale label Mar 13, 2020
@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants