Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Markdown] Newline in post is a character too late when a code block is used #259

Open
KyrneDev opened this issue Dec 11, 2018 · 4 comments

Comments

@KyrneDev
Copy link

KyrneDev commented Dec 11, 2018

Current Behavior
The codeblock causes a post to have a horizontal scroll bar on mobile when added as the last part of a line.

Steps to Reproduce

  1. Add a code block to a post which ends at the last character in a line (the "`" character is one character past where the new line should be)

Expected Behavior
The code block is moved to a new line

Screenshots

Environment

Additional Context
You can see the bug here: https://discuss.flarum.org/d/11006-twofactor-by-reflar/34

@franzliedke
Copy link

You are talking about the inline .htaccess code in the middle of the post, right?

@KyrneDev
Copy link
Author

@franzliedke correct.

@tobyzerner
Copy link

I'd say the best thing to do is to remove overflow: auto from .Post-body. Since overflow-wrap was added (flarum/framework@cde5d20), content overflowing shouldn't be a problem.

@franzliedke franzliedke added the good first issue Good for newcomers label Dec 13, 2018
@davwheat
Copy link
Member

Can't reproduce this on beta 13.

@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants