Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Approval] Create event for new unapproved post #117

Open
matteocontrini opened this issue Apr 2, 2021 · 2 comments
Open

[Approval] Create event for new unapproved post #117

matteocontrini opened this issue Apr 2, 2021 · 2 comments

Comments

@matteocontrini
Copy link

matteocontrini commented Apr 2, 2021

Feature Request

Is your feature request related to a problem? Please describe.

The approval extension doesn't currently have an event for when a new unapproved post is created.

Describe the solution you'd like

I'm not sure about naming conventions of Flarum events, but there would be something like NewUnapproved.

Alternatively, the approval extension should raise the flag-Created event. (While Deleting is already called when approving a post.)

@matteocontrini matteocontrini changed the title [Approval] Create events for approval/unapproval of posts [Approval] Create event for new unapproved post Apr 2, 2021
@stale
Copy link

stale bot commented Jul 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

@stale stale bot added the stale label Jul 8, 2021
@askvortsov1
Copy link
Member

askvortsov1 commented Aug 25, 2021

Couldn't we just hook into post created and check if the is_approved field is false?

Actually, nvm, since that's the field where is_approved would be set. Let's start with raising a "flag created" event.

@askvortsov1 askvortsov1 transferred this issue from flarum/framework Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants