Replace forum and admin global compat exports with a Proxy #2488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #2085.
Replaces flarum/flarum-webpack-config#7.
Adds ability for import statements of core & core extensions to include their namespaces (
forum
,admin
, andcommon
).We'll eventually require extensions use the namespaces in their imports. This PR makes them optional for extensions and allows extensions to continue working once we require them.
Original compat objects are left intact & do not contain the namespaces.
admin/utils/extract
--> returns importutils/extract
tags/common/utils/sortTags
--> returns importtags/utils/sortTags
Technically extensions can also use the incorrect namespace (forum/admin and common) as this code doesn't check whether it's correct. This shouldn't be a problem that we focus on, however.