Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When an extension dependency is not met, the extension page still switches to enabled #2536

Closed
clarkwinkelmann opened this issue Jan 12, 2021 · 0 comments · Fixed by #2558
Closed

When an extension dependency is not met, the extension page still switches to enabled #2536

clarkwinkelmann opened this issue Jan 12, 2021 · 0 comments · Fixed by #2558
Milestone
0.1.0-beta.16

Comments

@clarkwinkelmann
Copy link
Member

Bug Report

Current Behavior
When you try enabling an extension that doesn't have its extension dependency met, the error message is correctly shown and the extension is not enabled. However the page shows the extension as enabled until you change page.

Steps to Reproduce

  1. Go to admin panel
  2. Disable Approval & Flags
  3. Try to enable Approval
  4. Observe error message correctly shown
  5. Observe Switch stays in enabled state and page says "No settings" and "No permissions"

Expected Behavior
The page should switch back to disabled state upon error

Screenshots
Capture d’écran 2021-01-12 à 02 41 18

Environment

Additional Context
Observed locally. Reproduced on the demo website.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0-beta.16
Development

Successfully merging a pull request may close this issue.

Set this.changingState back to false in ExtensionPage if an error occurs flarum/framework
2 participants
@clarkwinkelmann @askvortsov1