Adjust boolean check of is_email_confirmed to suppress extraneous user activation events (#3163)

grimmdude · web-flow · commit 4ffc26a13a9d · 2021-11-11T15:51:47.000-05:00
diff --git a/src/User/User.php b/src/User/User.php
@@ -358,7 +358,7 @@ public function checkPassword($password)
      */
     public function activate()
     {
-        if ($this->is_email_confirmed !== true) {
+        if (! $this->is_email_confirmed) {
             $this->is_email_confirmed = true;
 
             $this->raise(new Activated($this));

Original file line number	Diff line number	Diff line change
`@@ -358,7 +358,7 @@ public function checkPassword($password)`
`358`	`358`	`*/`
`359`	`359`	`public function activate()`
`360`	`360`	`{`
`361`		`- if ($this->is_email_confirmed !== true) {`
	`361`	`+ if (! $this->is_email_confirmed) {`
`362`	`362`	`$this->is_email_confirmed = true;`
`363`	`363`
`364`	`364`	`$this->raise(new Activated($this));`