Skip to content
This repository was archived by the owner on Mar 11, 2025. It is now read-only.

Commit 9b298ee

Browse files
replace process.env.NODE_ENV at build time and enable react module-resolution build test
1 parent 7c88a10 commit 9b298ee

File tree

4 files changed

+51
-3
lines changed

4 files changed

+51
-3
lines changed

packages/vite-plugin-cloudflare/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
},
3737
"dependencies": {
3838
"@hattip/adapter-node": "^0.0.49",
39+
"@rollup/plugin-replace": "^6.0.1",
3940
"miniflare": "^3.20241205.0"
4041
},
4142
"devDependencies": {

packages/vite-plugin-cloudflare/src/cloudflare-environment.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import assert from 'node:assert';
22
import { builtinModules } from 'node:module';
3+
import replace from '@rollup/plugin-replace';
34
import * as vite from 'vite';
45
import { getNodeCompatExternals } from './node-js-compat';
56
import { INIT_PATH, UNKNOWN_HOST } from './shared';
@@ -153,6 +154,13 @@ export function createCloudflareEnvironmentOptions(
153154
// optimizeDeps.entries in the dev config)
154155
input: workerConfig.main,
155156
external: [...cloudflareBuiltInModules, ...getNodeCompatExternals()],
157+
plugins: [
158+
replace({
159+
'process.env.NODE_ENV': JSON.stringify(
160+
process.env.NODE_ENV ?? 'production',
161+
),
162+
}),
163+
],
156164
},
157165
},
158166
optimizeDeps: {

playground/module-resolution/__tests__/module-resolution.spec.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,7 @@ describe('module resolution', async () => {
7676
* special meaning to us.
7777
*/
7878
describe('third party packages resolutions', () => {
79-
// TODO: we skip this test on build because a `ReferenceError: process is not defined` is thrown
80-
// (https://github.com/flarelabs-net/vite-plugin-cloudflare/issues/82)
81-
test.skipIf(isBuild)('react', async () => {
79+
test('react', async () => {
8280
const result = await getJsonResponse('/third-party/react');
8381
expect(result).toEqual({
8482
'(react) reactVersionsMatch': true,

pnpm-lock.yaml

Lines changed: 41 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)