Enable clang warnings used by LLVM #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskeith
reviewed
Oct 2, 2019
tskeith
reviewed
Oct 2, 2019
tskeith
reviewed
Oct 2, 2019
tskeith
reviewed
Oct 2, 2019
tskeith
reviewed
Oct 2, 2019
jeanPerier
reviewed
Oct 2, 2019
sscalpone
reviewed
Oct 2, 2019
| // For switch statements whose cases have return statements for | ||
| // all possibilities. Clang emits warnings if the default: is | ||
| // present, gcc emits warnings if it is absent. | ||
| #if __clang__ |
There was a problem hiding this comment.
Please update the style guide.
tskeith
approved these changes
Oct 2, 2019
sscalpone
approved these changes
Oct 2, 2019
jeanPerier
approved these changes
Oct 2, 2019
DavidTruby
reviewed
Oct 3, 2019
| @@ -585,9 +585,6 @@ void OmpStructureChecker::Enter( | |||
| OmpClauseSet allowed{OmpClause::DEPEND}; | |||
| SetContextAllowed(allowed); | |||
| } break; | |||
| default: | |||
| // TODO others | |||
| break; | |||
There was a problem hiding this comment.
This switch statement should also have SWITCH_COVERS_ALL_CASES as per the updated style guide
There was a problem hiding this comment.
@klausler looks like @DavidTruby's comment fell through the cracks. @DavidTruby - can you submit a separate PR for it?
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@c6b3420 Reviewed-on: flang-compiler/f18#774 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@8ebfd8d Reviewed-on: flang-compiler/f18#774 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@b2a0503 Reviewed-on: flang-compiler/f18#774 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@48b81a2 Reviewed-on: flang-compiler/f18#774 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@7e11f81 Reviewed-on: flang-compiler/f18#774 Tree-same-pre-rewrite: false
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Apr 9, 2020
Original-commit: flang-compiler/f18@6e269b4 Reviewed-on: flang-compiler/f18#774
swift-ci
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Apr 9, 2020
…/pmk-more-warnings Enable clang warnings used by LLVM Original-commit: flang-compiler/f18@c098156 Reviewed-on: flang-compiler/f18#774
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@c6b3420 Reviewed-on: flang-compiler/f18#774 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@8ebfd8d Reviewed-on: flang-compiler/f18#774 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@b2a0503 Reviewed-on: flang-compiler/f18#774 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@48b81a2 Reviewed-on: flang-compiler/f18#774 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@7e11f81 Reviewed-on: flang-compiler/f18#774 Tree-same-pre-rewrite: false
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Original-commit: flang-compiler/f18@6e269b4 Reviewed-on: flang-compiler/f18#774
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
-Wstring-conversionand-Wcovered-switch-defaultwarnings when building with clang. Patch sources to dodge the warnings.