FIX FHIR result set resource type #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using FHIR R4 models in the resource_type parameter, it is always ignored and instantiates the latest model (R5).
joaodaher
reviewed
Apr 9, 2025
| @@ -175,7 +175,7 @@ def get_page_resources(self) -> Generator[DomainResource]: | |||
| return | |||
|
|
|||
| for entry in self.response["entry"]: | |||
| resource_class = get_fhir_model_class(entry["resource"]["resourceType"]) | |||
| resource_class = self.resource_class or get_fhir_model_class(entry["resource"]["resourceType"]) | |||
There was a problem hiding this comment.
Do you think we should fail/warn when the self.resource_class does not match the response's resourceType?
Also, shouldn't the response's resourceType be more important? I'm thinking about results that might have a bunch of mixed resource types (Patient, Appointment, Encounter), and if we use the response's resourceType, we'll be able to properly build those resources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using FHIR R4 models in the resource_type parameter, it is always ignored and instantiates the latest model version (current is R5).