Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--Region does not understand pixel scaling (DPI) #2780

Open
wd5gnr opened this issue Jul 11, 2022 · 7 comments
Open

--Region does not understand pixel scaling (DPI) #2780

wd5gnr opened this issue Jul 11, 2022 · 7 comments
Labels
Bug It's a bug

Comments

@wd5gnr
Copy link
Contributor

wd5gnr commented Jul 11, 2022

Flameshot Version

Current

Installation Type

Compiled from source

Operating System type and version

KDE Neon

Description

I noticed that with KDE scaling (1.25X) the region argument on CLI gets confused

 xdotool getwindowgeometry --shell 8126472
WINDOW=8126472
X=1920
Y=1121
WIDTH=1920
HEIGHT=1037
SCREEN=0

Then
flameshot gui --region 1920x1037+1920+1121
Does not do what you expect

Since the scale is 1.25:

flameshot gui --region 1536x830+1536+897

works.

ATM don't have time to run down where this is happening, but it has to be scale on those arguments.

Steps to reproduce

Set scaling to something other than 1

Find coordinates on the screen you are sure of

Run with --region argument

Note that the region is incorrect

Screenshots or screen recordings

No response

System Information

KDE Neon

@wd5gnr wd5gnr added the Unconfirmed Bug The bug is not confirmed by anyone else. label Jul 11, 2022
@wd5gnr
Copy link
Contributor Author

wd5gnr commented Jul 11, 2022

@mmahmoudian This affects your excellent dmenu script adversely, also. I stripped part of it out and was using it successfully until I changed scaling which is what had me notice this.

@mmahmoudian
Copy link
Member

I'm on Manjaro KDE and to me it seems everything works fine with global fractional scaling 125%:

Peek.2022-07-11.17-39.mp4

@wd5gnr
Copy link
Contributor Author

wd5gnr commented Jul 11, 2022

Can you try if your font DPI is forced? Appearance | Fonts, Force font DPI? I also have that set so maybe that's the issue. Then the question is does that matter. But I think it has worked before with that set for me and it has been since the 1.25x. I just rebooted so I will try again.

@wd5gnr
Copy link
Contributor Author

wd5gnr commented Jul 11, 2022

Update: with DPI scalling set off and at 1.25x the same problem occurs here. Very odd..

@wd5gnr
Copy link
Contributor Author

wd5gnr commented Jul 11, 2022

I put a ruler wallpaper down. The Konsole window, xdotool reports as 1934x1276+959+427 which is pretty close to what you can read from the scale. Ignoring my mistake of using --gui the first time, the second run is captured with --region, and you can see it is off about the 25%.

https://imgur.com/a/IkkhxLI

@borgmanJeremy
Copy link
Contributor

Yes I can reproduce this on MacOS as well.

@borgmanJeremy borgmanJeremy added Bug It's a bug and removed Unconfirmed Bug The bug is not confirmed by anyone else. labels Jul 12, 2022
@cedric-h
Copy link

cedric-h commented Nov 9, 2022

it's mentioned in a merged PR -- can this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug It's a bug
Projects
None yet
Development

No branches or pull requests

4 participants