Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the marker for highlighting text #1085

Closed
PrSunflower opened this issue Oct 20, 2020 · 4 comments
Closed

Improve the marker for highlighting text #1085

PrSunflower opened this issue Oct 20, 2020 · 4 comments
Labels
Enhancement Feature requests and code enhancements

Comments

@PrSunflower
Copy link
Contributor

PrSunflower commented Oct 20, 2020

Hi, I really like Flameshot, thanks to all the developers who have worked on it!

Suggestion

I use the marker to highlight text and it looks very pale, to compensate I often have to highlight multiple times which is annoying. The best highlighter I know is from Windows's Snip & Sketch so I did a comparison below:

Black text on light background

Flameshot:
Flameshot_WHITE

Snip & Sketch:
Snip_and_Sketch_WHITE


White text on dark background

Flameshot:
Flameshot_BLACK

Snip & Sketch:
Snip_and_Sketch_BLACK


More details

Flameshot does a good job at keeping the text visible so this is not linked to my request:

image

image


My request is to improve the opacity of the Marker tool in order to make the highlighting of text more visible.

@holazt holazt added the Enhancement Feature requests and code enhancements label Oct 21, 2020
@mmahmoudian
Copy link
Member

Perhaps we can add a slider in the Tool Settings so that users can adjust the opacity from that menu.

@PrSunflower
Copy link
Contributor Author

@mmahmoudian That would be really nice!

@borgmanJeremy
Copy link
Contributor

Also a duplicate of #249. If we add it to Tool settings it would likely be global opacity. Is this okay? Maybe we should get RFC feedback so we only need to implement it once.

@PrSunflower
Copy link
Contributor Author

@borgmanJeremy Oh right, I haven't stumbled upon this issue before creating mine.

I agree with the global opacity setting. If I understand well this opacity slider will also influence the pencil, rectangle, circle etc. and I agree with that.

Thanks for replying, now closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and code enhancements
Projects
None yet
Development

No branches or pull requests

4 participants