Add an option to change the complex return type. #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifort apparently does not return complex numbers in registers as in C/C++ (or gfortran), but instead creates a "hidden" first parameter for the return value. The option --complex-return=gnu|intel has been added, as well as a guess based on a provided FC if not specified (otherwise default to gnu). This option affects the signatures of cdotc, cdotu, zdotc, and zdotu, and a single library cannot be used with both GNU and Intel Fortran compilers. Fixes #433.
|
@fgvanzee this one too. |
isuruf
reviewed
Sep 7, 2020
configure
Outdated
| elif [ "x${complex_return}" = "xintel" ]; then | ||
| complex_return_intel01='1' | ||
| else | ||
| echo "${script_name}: unknown complex return type \"${complex_return}\"! Cannot continue." |
There was a problem hiding this comment.
Can we make this default to gnu if not given to not break scripts building BLIS?
There was a problem hiding this comment.
@isuruf it does default to gnu if FC isn't specified explicitly. Do you mean to use gnu even if FC is set?
There was a problem hiding this comment.
Ah, you are right. Didn't read the code correctly. Sorry
There was a problem hiding this comment.
No prob, thanks for the extra set of eyes.
|
Reviewing... |
fgvanzee
approved these changes
Sep 7, 2020
|
All tests passed before the last commit which is just whitespace stuff, so I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ifort apparently does not return complex numbers in registers as in C/C++ (or gfortran), but instead creates a "hidden" first parameter for the return value. The option --complex-return=gnu|intel has been added, as well as a guess based on a provided FC if not specified (otherwise default to gnu). This option affects the signatures of cdotc, cdotu, zdotc, and zdotu, and a single library cannot be used with both GNU and Intel Fortran compilers. Fixes #433.