feat: Add support to multiple lights using the uniform array [flame3d][WIP]#3284
Draft
luanpotter wants to merge 3 commits intomainfrom
Draft
feat: Add support to multiple lights using the uniform array [flame3d][WIP]#3284luanpotter wants to merge 3 commits intomainfrom
luanpotter wants to merge 3 commits intomainfrom
Conversation
6 tasks
luanpotter
force-pushed
the
luan.shader-arrays
branch
2 times, most recently
from
8158d30 to
9132ee8
Compare
luanpotter
force-pushed
the
luan.multi-lights
branch
from
9fb50a3 to
02b35b4
Compare
1 task
luanpotter
added a commit
that referenced
this pull request
Sep 21, 2024
…_3d] (#3282) Refactor shader uniform binding to support shader arrays. This also decouples the whole shader and uniform byte handling code (that we should definitely test) from the flutter_gpu primitives that are impossible to mock (base native classes). This adds tests that ensure the arrays are bound as they should - however the underlying flutter_gpu code does not seem to work. See [this PR](#3284) for a test of using this to support an arbitrary number of lights. Either way, we can merge this as is as this refactors the underlying structure to support arrays when ready, and make it more testable as well.
luanpotter
added a commit
that referenced
this pull request
Oct 15, 2024
…_3d] (#3282) Refactor shader uniform binding to support shader arrays. This also decouples the whole shader and uniform byte handling code (that we should definitely test) from the flutter_gpu primitives that are impossible to mock (base native classes). This adds tests that ensure the arrays are bound as they should - however the underlying flutter_gpu code does not seem to work. See [this PR](#3284) for a test of using this to support an arbitrary number of lights. Either way, we can merge this as is as this refactors the underlying structure to support arrays when ready, and make it more testable as well.
luanpotter
added a commit
that referenced
this pull request
Dec 11, 2024
…_3d] (#3282) Refactor shader uniform binding to support shader arrays. This also decouples the whole shader and uniform byte handling code (that we should definitely test) from the flutter_gpu primitives that are impossible to mock (base native classes). This adds tests that ensure the arrays are bound as they should - however the underlying flutter_gpu code does not seem to work. See [this PR](#3284) for a test of using this to support an arbitrary number of lights. Either way, we can merge this as is as this refactors the underlying structure to support arrays when ready, and make it more testable as well.
luanpotter
force-pushed
the
luan.multi-lights
branch
from
02b35b4 to
b8762ec
Compare
luanpotter
added a commit
that referenced
this pull request
Dec 11, 2024
…_3d] (#3282) Refactor shader uniform binding to support shader arrays. This also decouples the whole shader and uniform byte handling code (that we should definitely test) from the flutter_gpu primitives that are impossible to mock (base native classes). This adds tests that ensure the arrays are bound as they should - however the underlying flutter_gpu code does not seem to work. See [this PR](#3284) for a test of using this to support an arbitrary number of lights. Either way, we can merge this as is as this refactors the underlying structure to support arrays when ready, and make it more testable as well.
luanpotter
force-pushed
the
luan.multi-lights
branch
from
b8762ec to
416acd7
Compare
luanpotter
force-pushed
the
luan.multi-lights
branch
from
416acd7 to
3e36235
Compare
luanpotter
force-pushed
the
luan.multi-lights
branch
from
e49e5aa to
55c1aad
Compare
Member
Author
|
@wolfenrain would love some help with getting this working when you have some time. I've tried so many different approaches and the issue truly eludes me. |
Contributor
I'll try and have a jab at it 🫡 |
nickf2k
pushed a commit
to nickf2k/flame
that referenced
this pull request
Nov 16, 2025
…_3d] (flame-engine#3282) Refactor shader uniform binding to support shader arrays. This also decouples the whole shader and uniform byte handling code (that we should definitely test) from the flutter_gpu primitives that are impossible to mock (base native classes). This adds tests that ensure the arrays are bound as they should - however the underlying flutter_gpu code does not seem to work. See [this PR](flame-engine#3284) for a test of using this to support an arbitrary number of lights. Either way, we can merge this as is as this refactors the underlying structure to support arrays when ready, and make it more testable as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support to multiple lights using the uniform array
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?