Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with WebRTC #5

Closed
icidasset opened this issue Jul 3, 2020 · 3 comments
Closed

Fix issues with WebRTC #5

icidasset opened this issue Jul 3, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@icidasset
Copy link
Contributor

icidasset commented Jul 3, 2020

For some reason it doesn't work at all on Safari.
It gives an error that WebRTC is not supported, even though it is.

I looked at various apps that use https://github.com/libp2p/js-libp2p-webrtc-star as well,
and it doesn't look like there is any special setup neccessary for Safari.

Examples:

No clue what's going on 🤷


That said, it looks like a better implementation is underway. About the *-star libraries:

These were never designed to be long term solutions, in fact, they were designed to be quick tools for demos. They have design flaws and worse, they end up re-implementing a lot of what libp2p already does (connection authentication, peer discovery, circuit-relay and rendezvous)

Source: libp2p/js-libp2p#385

@icidasset icidasset added the bug Something isn't working label Jul 3, 2020
@icidasset
Copy link
Contributor Author

More notes:

@icidasset
Copy link
Contributor Author

UPDATE:
Works for the most part with the circuit relay setup.
Still some issues with Safari.
Does not work at all on iOS Firefox and iOS Chrome, see ipfs/js-ipfs-utils#50 for more info.

@icidasset
Copy link
Contributor Author

Looks like it's fixed 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant