update api, implement example #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czerwiukk
reviewed
Oct 13, 2025
czerwiukk
reviewed
Oct 13, 2025
| "peer_name": peer_name, | ||
| } | ||
| ) | ||
| except Exception as e: |
Member
There was a problem hiding this comment.
nitpick: isn't except Exception bit too general?
Member
Author
There was a problem hiding this comment.
I think it's fine for the usecase
Member
AHGIJMKLKKZNPJKQR
left a comment
AHGIJMKLKKZNPJKQR
left a comment
There was a problem hiding this comment.
first notes, more tomorrow
AHGIJMKLKKZNPJKQR
requested changes
Oct 14, 2025
examples/selective_subscription/selective_subscription/config.py
Outdated
Show resolved
Hide resolved
examples/selective_subscription/selective_subscription/room_service.py
Outdated
Show resolved
Hide resolved
examples/selective_subscription/selective_subscription/room_service.py
Outdated
Show resolved
Hide resolved
examples/selective_subscription/selective_subscription/room_service.py
Outdated
Show resolved
Hide resolved
AHGIJMKLKKZNPJKQR
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes FCE-1955
Motivation and Context
Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.
Documentation impact
Types of changes
not work as expected)