Merge pull request #11 from firstandthird/checkIfExists

checkIfExists

Author: orthagonal

index.js

@@ -1,12 +1,26 @@
 'use strict';
 const useragent = require('useragent');
+const wreck = require('wreck');
+
 module.exports = (server, options, allDone) => {
   options = options || {};
   if (!options.method) {
     return allDone(new Error('hapi-trailing-slash plugin registered without specifiying which method to use'));
   }
   options.statusCode = options.statusCode || 301;
 
+  const redirectExists = (redirectPath, callback) => {
+    if (!options.checkIfExists) {
+      return callback(true);
+    }
+    wreck.request('head', redirectPath, {}, (err, res) => {
+      if (err) {
+        return callback(false);
+      }
+      return callback(res.statusCode < 400);
+    });
+  };
+
   const doRedirect = (path, request, reply) => {
     const redirectTo = request.url.search ? path + request.url.search : path;
     if (options.verbose) {
@@ -39,10 +53,15 @@ module.exports = (server, options, allDone) => {
       if (request.path.indexOf('.') !== -1) {
         return reply.continue();
       }
-
       // pick a redirection based on either 'append' or 'remove' mode:
       const redirectPath = options.method === 'append' ? `${request.path}/` : request.path.replace(/\/$/, '');
-      return doRedirect(redirectPath, request, reply);
+      return redirectExists(redirectPath, (exists) => {
+        if (exists) {
+          doRedirect(redirectPath, request, reply);
+        } else {
+          return reply.continue();
+        }
+      });
     }
     // otherwise it really is a 404:
     return reply.continue();

package.json

@@ -29,6 +29,7 @@
     "lab": "^13.0.1"
   },
   "dependencies": {
-    "useragent": "^2.2.1"
+    "useragent": "^2.2.1",
+    "wreck": "^12.0.0"
   }
 }

test/checkIfExists.test.js

@@ -0,0 +1,66 @@
+'use strict';
+const Code = require('code');   // assertion library
+const Lab = require('lab');
+const lab = exports.lab = Lab.script();
+const Hapi = require('hapi');
+const theModule = require('../index.js');
+
+lab.experiment('hapi-trailing-slash checkIfExists', () => {
+  let server;
+
+  lab.beforeEach((done) => {
+    server = new Hapi.Server();
+    server.connection();
+
+    server.route([
+      {
+        method: 'GET',
+        path: '/no/slash',
+        handler: (request, reply) => {
+          reply('chinese democracy');
+        }
+      },
+      {
+        method: 'GET',
+        path: '/has/slash/',
+        handler: (request, reply) => {
+          reply('slither').code(301);
+        }
+      },
+    ]);
+
+    server.register({
+      register: theModule,
+      options: {
+        checkIfExists: true,
+        method: 'remove',
+        verbose: true
+      }
+    }, (err) => {
+      if (err) {
+        throw err;
+      }
+      server.start(done);
+    });
+  });
+
+  lab.afterEach((done) => {
+    server.stop(done);
+  });
+
+  lab.test(' checkIfExists will do a HEAD check that the forward exists', (done) => {
+    server.inject({
+      method: 'get',
+      url: '/no/slash/'
+    }, (result) => {
+      Code.expect(result.statusCode).to.equal(404);
+      server.inject({
+        method: 'get',
+        url: '/has/slash/'
+      }, (result2) => {
+        Code.expect(result2.statusCode).to.equal(301);
+        done();
+      });
+    });
+  });
+});