Fix issue with failing GetAddressGroupings with Private Spends #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thebevrishot good catch. Updated |
a-bezrukov
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #723
PR intention
GetAddressGroupings()inwallet/wallet.cppis causing a segfault if the wallet contains Zerocoin or Sigma spends. The issue is it expects each input of the transaction it's looking at to be associated with an address, spend inputs are not.Code changes brief
Avoid the code block that deals with inputs entirely by checking if the overall tx is a spend. This is sufficient as spends cannot have non-spend inputs.