restored Serial.begin(speed) to earlier version #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lled at correct time
| @@ -67,14 +67,18 @@ void FirmataClass::begin(void) | |||
| void FirmataClass::begin(long speed) | |||
| { | |||
| Serial.begin(speed); | |||
| begin(Serial); | |||
| blinkVersion(); | |||
There was a problem hiding this comment.
This was in the wrong order.
soundanalogous
added a commit
that referenced
this pull request
Jun 19, 2013
restored Serial.begin(speed) to earlier version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so so blinkVersion is called at correct time. Had to remove call to begin(Serial) from begin(long speed) because we need FirmataSerial declared and don't want to call blinkVersion for the Stream version of the begin method. This is because hardware such as the ethernet shield use pin 13 (which is the blink pin on the Arduino Uno and similar boards).