None option for Riesz Representation in derivatives #3552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ig-dolci
changed the title
dham
reviewed
May 2, 2024
dham
requested changes
May 2, 2024
Member
dham
left a comment
dham
left a comment
There was a problem hiding this comment.
I think this is a good workaround. Just needs a test.
Ig-dolci
changed the title
dham
requested changes
May 8, 2024
Default to L2 projection.
dham
approved these changes
May 8, 2024
juliusgh
pushed a commit
to juliusgh/firedrake
that referenced
this pull request
May 13, 2024
…#3552) Also default to L2 projection. --------- Co-authored-by: David A. Ham <david.ham@imperial.ac.uk> Co-authored-by: Jack Betteridge <43041811+JDBetteridge@users.noreply.github.com>
Ig-dolci
added a commit
that referenced
this pull request
Jul 6, 2024
Also default to L2 projection. --------- Co-authored-by: David A. Ham <david.ham@imperial.ac.uk> Co-authored-by: Jack Betteridge <43041811+JDBetteridge@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReducedFunctional.derivativereturns a gradient in the primal space, differing from conventional terminology. Addressing this in Pyadjoint requires additional thoughts. To accommodate users seeking the derivative is to introduce"None"as an option forriesz_representation.