Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for block sparsity fix #3073

Merged

Conversation

connorjward
Copy link
Contributor

Fixes #3066

Requires OP2/PyOP2#704

I think that my test could be better. Suggestions welcome.

dham
dham previously approved these changes Aug 23, 2023
Copy link
Member

@JDBetteridge JDBetteridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in meeting

@JDBetteridge JDBetteridge enabled auto-merge (squash) August 30, 2023 16:01
@JDBetteridge JDBetteridge merged commit 6410776 into master Aug 30, 2023
10 checks passed
@JDBetteridge JDBetteridge deleted the connorjward/fix-block-sparsity-for-boundary-integrals branch August 30, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with boundary integral and VectorFunctionSpace
3 participants