Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiling every local kernel invocation should not be enabled without explicitly asking #3822

Open
connorjward opened this issue Sep 4, 2024 · 0 comments
Labels

Comments

@connorjward
Copy link
Contributor

At present we add PETSc events to local kernels if PETSc logging is enabled (i.e. we pass -log_view).
In my recent performance experiments it is clear that this can actually be quite costly so enabling it by default like this is probably unwise. I think instead we should add a add_petsc_event parameter to tsfc_compiler_parameters so we have more control on when it is applied.

@connorjward connorjward transferred this issue from firedrakeproject/tsfc Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant