Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer managers for icosahedral sphere mesh #29

Open
JHopeCollins opened this issue May 3, 2022 · 1 comment
Open

Transfer managers for icosahedral sphere mesh #29

JHopeCollins opened this issue May 3, 2022 · 1 comment
Labels
Non-core utilities Necessary or QOL functionality not directly part of paradiag refactor Tidy up existing functionality

Comments

@JHopeCollins
Copy link
Collaborator

The block solves for the non-linear shallow water equations example needs a bespoke transfer manager for the icosahedral sphere mesh.
This manager deals with the fact that refinements of the icosahedral sphere are not nested, so the fine mesh coordinates need to be projected down onto the surface of the coarse mesh to carry out the transfers.

This is probably general enough that it could/should be supported by Firedrake directly. If this happens, we can remove the file in the examples directory that currently defines this transfer manager.

@JHopeCollins
Copy link
Collaborator Author

JHopeCollins commented May 10, 2022

This functionality has now been moved to the utils library in utils.mg
See pull request #35

The plan is still to propose it to be included in Firedrake, but for now we no longer need to carry the mg file around in the examples folder.

@colinjcotter colinjcotter added the enhancement New feature or request label May 11, 2022
@JHopeCollins JHopeCollins added refactor Tidy up existing functionality Non-core utilities Necessary or QOL functionality not directly part of paradiag and removed enhancement New feature or request labels May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non-core utilities Necessary or QOL functionality not directly part of paradiag refactor Tidy up existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants