seccomp: do not build default seccomp policy in debug builds #5052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5052 +/- ##
=======================================
Coverage 83.19% 83.19%
=======================================
Files 247 247
Lines 26641 26641
=======================================
Hits 22163 22163
Misses 4478 4478
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Manciukic
force-pushed
the
debug-seccomp
branch
from
46b6545 to
7850483
Compare
Rust 1.80.0 added a debug assertion that uses fcntl(F_GETFD) to ensure the fd is still valid when it gets dropped, which broke debug builds of firecracker. This made us rethink on whether we'd want any default seccomp policy in debug builds, and we decided that in most cases we don't need them and in some cases they get in the way of prororyping and debugging. This patch changes the default seccomp policy in debug builds to empty. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
Manciukic
force-pushed
the
debug-seccomp
branch
2 times, most recently
from
6fdc014 to
a4cd0cb
Compare
Manciukic
changed the title
Manciukic
added
the
Status: Awaiting review
pb8o
reviewed
Mar 3, 2025
pb8o
previously approved these changes
Mar 3, 2025
Following the previous commit, this patch mentions in the docs that debug builds don't have a default seccomp policy and which different syscalls are present in debug builds versus release. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
This patch adds an entry to the "Fixed" changelog list mentioning that debug builds are now built with an empty default seccomp policy. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
|
Updates:
|
roypat
approved these changes
Mar 3, 2025
kalyazin
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This patch changes the default seccomp policy in debug builds to empty.
Reason
Rust 1.80.0 added a debug assertion that uses fcntl(F_GETFD) to ensure
the fd is still valid when it gets dropped, which broke debug builds of
firecracker.
This made us rethink on whether we'd want any default seccomp policy in
debug builds, and we decided that in most cases we don't need them and
in some cases they get in the way of prororyping and debugging.
Areas of focus
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.