Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): ensure debuginfo file contains debugging info #4790

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

pb8o
Copy link
Contributor

@pb8o pb8o commented Sep 9, 2024

Seems recently Cargo defaulted to use strip=debuginfo. This inadvertently made our debuginfo files much smaller and that much less useful.

Fix the issue by using strip=none and add a test so that it breaks if this somehow changes again.

Changes

  • Fix debuginfo files
  • Move the test together with the static link check as they are similar.

Reason

debuginfo files can be used to troubleshoot issues, so we want to keep them functional.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@pb8o pb8o added the Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` label Sep 9, 2024
@pb8o pb8o self-assigned this Sep 9, 2024
@pb8o pb8o marked this pull request as ready for review September 9, 2024 13:09
@pb8o pb8o added the Status: Awaiting author Indicates that an issue or pull request requires author action label Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.32%. Comparing base (0661dd7) to head (54da2bf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4790   +/-   ##
=======================================
  Coverage   84.32%   84.32%           
=======================================
  Files         249      249           
  Lines       27512    27512           
=======================================
+ Hits        23199    23200    +1     
+ Misses       4313     4312    -1     
Flag Coverage Δ
5.10-c5n.metal 84.54% <ø> (ø)
5.10-m5n.metal 84.53% <ø> (ø)
5.10-m6a.metal 83.82% <ø> (ø)
5.10-m6g.metal 80.90% <ø> (ø)
5.10-m6i.metal 84.52% <ø> (ø)
5.10-m7g.metal 80.90% <ø> (ø)
6.1-c5n.metal 84.54% <ø> (?)
6.1-m5n.metal 84.53% <ø> (?)
6.1-m6a.metal 83.82% <ø> (?)
6.1-m6g.metal 80.90% <ø> (?)
6.1-m6i.metal 84.52% <ø> (?)
6.1-m7g.metal 80.90% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pb8o pb8o added Status: Awaiting review Indicates that a pull request is ready to be reviewed and removed Status: Awaiting author Indicates that an issue or pull request requires author action labels Sep 11, 2024
roypat
roypat previously approved these changes Sep 12, 2024
@pb8o pb8o force-pushed the fix-debuginfo branch 2 times, most recently from 664a4f3 to 73b29c6 Compare September 12, 2024 14:00
roypat
roypat previously approved these changes Sep 13, 2024
@pb8o pb8o force-pushed the fix-debuginfo branch 4 times, most recently from cf26e1e to 11ef07f Compare September 16, 2024 15:18
roypat
roypat previously approved these changes Sep 16, 2024
@pb8o pb8o changed the title fix(release): ensure debuginfo file contain debugging info fix(release): ensure debuginfo file contains debugging info Sep 16, 2024
@pb8o pb8o closed this Sep 17, 2024
@pb8o pb8o reopened this Sep 17, 2024
@pb8o pb8o requested a review from xmarcalx as a code owner September 17, 2024 07:06
Seems recently Cargo defaulted to use `strip=debuginfo`. This
inadvertently made our debuginfo files much smaller

Fix the issue by using `strip=none` and add a test so that it breaks if
this somehow changes again.

Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
@pb8o pb8o merged commit 24819a0 into firecracker-microvm:main Sep 17, 2024
6 of 7 checks passed
@pb8o pb8o deleted the fix-debuginfo branch September 17, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants