-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(release): ensure debuginfo file contains debugging info #4790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4790 +/- ##
=======================================
Coverage 84.32% 84.32%
=======================================
Files 249 249
Lines 27512 27512
=======================================
+ Hits 23199 23200 +1
+ Misses 4313 4312 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roypat
previously approved these changes
Sep 12, 2024
roypat
reviewed
Sep 12, 2024
664a4f3
to
73b29c6
Compare
roypat
previously approved these changes
Sep 13, 2024
kalyazin
reviewed
Sep 13, 2024
pb8o
commented
Sep 16, 2024
cf26e1e
to
11ef07f
Compare
roypat
previously approved these changes
Sep 16, 2024
roypat
approved these changes
Sep 17, 2024
Seems recently Cargo defaulted to use `strip=debuginfo`. This inadvertently made our debuginfo files much smaller Fix the issue by using `strip=none` and add a test so that it breaks if this somehow changes again. Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
ShadowCurse
approved these changes
Sep 17, 2024
kalyazin
approved these changes
Sep 17, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority: Low
Indicates that an issue or pull request should be resolved behind issues or pull requests labelled `
Status: Awaiting review
Indicates that a pull request is ready to be reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems recently Cargo defaulted to use
strip=debuginfo
. This inadvertently made our debuginfo files much smaller and that much less useful.Fix the issue by using
strip=none
and add a test so that it breaks if this somehow changes again.Changes
debuginfo
filesReason
debuginfo
files can be used to troubleshoot issues, so we want to keep them functional.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
PR.
CHANGELOG.md
.TODO
s link to an issue.contribution quality standards.
rust-vmm
.