Drop support for Linux host 4.14 #4689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb8o
added
Priority: Low
Kernel 4.14 has reached End of Life and is not supported by upstream. This should also reduce our CI costs by 1/3. Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
We are dropping support for Linux host 4.14, so we don't need a special 5.10 guest kernel anymore. Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
We are dropping support for Linux 4.14 so they are no longer needed. Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
We are dropping support for Linux 4.14 so reflect it in the docs. Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
Remove code to support Linux 4.14. Firecracker/Jailer will only work with kernel 5.10 and above. Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
Fix typo in the documentation Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4689 +/- ##
==========================================
- Coverage 82.16% 81.92% -0.24%
==========================================
Files 255 253 -2
Lines 31361 31108 -253
==========================================
- Hits 25768 25486 -282
- Misses 5593 5622 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pb8o
added
Status: Awaiting review
zulinx86
approved these changes
Jul 18, 2024
xmarcalx
approved these changes
Jul 18, 2024
ShadowCurse
approved these changes
Jul 18, 2024
4 tasks
roypat
added a commit
to roypat/firecracker
that referenced
this pull request
Jul 22, 2024
io_uring is not supported on 4.14 hosts. Since firecracker-microvm#4689 dropped support for 4.14 hosts, and 5.10 does support io_uring, remove various checks related to unsupported (4.14) host kernels. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
added a commit
to roypat/firecracker
that referenced
this pull request
Jul 23, 2024
io_uring is not supported on 4.14 hosts. Since firecracker-microvm#4689 dropped support for 4.14 hosts, and 5.10 does support io_uring, remove various checks related to unsupported (4.14) host kernels. Also update some of our unittests to always test both the sync and async block engines. Previously, we only tested the sync engine on 4.14 hosts, and only the async engien on 5.10 hosts. With the removal of 4.14 hosts, this meant that we were no longer unittesting the sync engine in these tests at all. Thus, have all the tests unconditionally test both engines. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
zulinx86
pushed a commit
that referenced
this pull request
Jul 23, 2024
io_uring is not supported on 4.14 hosts. Since #4689 dropped support for 4.14 hosts, and 5.10 does support io_uring, remove various checks related to unsupported (4.14) host kernels. Also update some of our unittests to always test both the sync and async block engines. Previously, we only tested the sync engine on 4.14 hosts, and only the async engien on 5.10 hosts. With the removal of 4.14 hosts, this meant that we were no longer unittesting the sync engine in these tests at all. Thus, have all the tests unconditionally test both engines. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
ghost
pushed a commit
to JamesC1305/firecracker
that referenced
this pull request
Aug 14, 2024
io_uring is not supported on 4.14 hosts. Since firecracker-microvm#4689 dropped support for 4.14 hosts, and 5.10 does support io_uring, remove various checks related to unsupported (4.14) host kernels. Also update some of our unittests to always test both the sync and async block engines. Previously, we only tested the sync engine on 4.14 hosts, and only the async engien on 5.10 hosts. With the removal of 4.14 hosts, this meant that we were no longer unittesting the sync engine in these tests at all. Thus, have all the tests unconditionally test both engines. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Drop support for running Firecracker on host Linux 4.14
Reason
Linux 4.14 has been EOL since January 2024.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.