[1.7] backport IO metrics from main #4490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to collect metrics depending on the number of remaining requests in the queue. (cherry picked from commit d480849) Signed-off-by: Nikita Kalyazin <kalyazin@amazon.com>
This is for it to be available in block and net modules. (cherry picked from commit 430a034) Signed-off-by: Nikita Kalyazin <kalyazin@amazon.com>
LatencyAggregateMetrics metrics are dictionaries rather than ints, so they require special treatment. (cherry picked from commit 012a38a) Signed-off-by: Nikita Kalyazin <kalyazin@amazon.com>
These metrics measure how long Firecracker VMM thread is blocked on the read/write syscalls when accessing data in the drive file. By looking at them, we will be able to see what portion of block latency is attributed to factors external to Firecracker. (cherry picked from commit e00d62d) Signed-off-by: Nikita Kalyazin <kalyazin@amazon.com>
This metric accumulates the number of pending requests sitting in the virtio queue while a request is being processed. By looking at this number, one may make a decision on whether an async IO solution would be beneficial. (cherry picked from commit 58a87ed) Signed-off-by: Nikita Kalyazin <kalyazin@amazon.com>
This metric measures how long Firecracker VMM thread is blocked on the write syscalls when accessing a tap device. By looking at it, we will be able to see what portion of tx net latency is attributed to factors external to Firecracker. (cherry picked from commit f7d8a33) Signed-off-by: Nikita Kalyazin <kalyazin@amazon.com>
This metric accumulates the number of pending requests sitting in the Tx virtio queue while a request is being processed. This may give an insight at how sensible it would be to think of processing ingress traffic parallelly. (cherry picked from commit 3753f35) Signed-off-by: Nikita Kalyazin <kalyazin@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## firecracker-v1.7 #4490 +/- ##
====================================================
+ Coverage 81.63% 81.65% +0.01%
====================================================
Files 243 243
Lines 29803 29834 +31
====================================================
+ Hits 24329 24360 +31
Misses 5474 5474
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kalyazin
added
the
Status: Awaiting review
ShadowCurse
previously approved these changes
Mar 8, 2024
roypat
previously approved these changes
Mar 8, 2024
wearyzen
previously approved these changes
Mar 8, 2024
wearyzen
reviewed
Mar 8, 2024
- block/net file/tap access latencies - block/net virtio queue backlog lengths (cherry picked from commit 448df60) Signed-off-by: Nikita Kalyazin <kalyazin@amazon.com>
kalyazin
dismissed stale reviews from wearyzen, roypat, and ShadowCurse
via
afb0c25
wearyzen
approved these changes
Mar 8, 2024
roypat
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Backporting extra IO metrics (#4486) from main.
Reason
We would like for them to appear in prod as soon as possible.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] If a specific issue led to this PR, this PR closes the issue.PR.
[ ] API changes follow the Runbook for Firecracker API changes.CHANGELOG.md.[ ] All added/changed functionality is tested.[ ] NewTODOs link to an issue.contribution quality standards.
rust-vmm.