test(metrics): collect Firecracker vhost-user metrics #4246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4246 +/- ##
=======================================
Coverage 81.69% 81.69%
=======================================
Files 240 240
Lines 29293 29293
=======================================
Hits 23932 23932
Misses 5361 5361
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Blocked on #4223 to add 1 more metric |
kalyazin
reviewed
Nov 20, 2023
kalyazin
reviewed
Nov 27, 2023
roypat
reviewed
Nov 27, 2023
pb8o
reviewed
Nov 29, 2023
kalyazin
reviewed
Nov 29, 2023
kalyazin
reviewed
Nov 29, 2023
Add a test to boot a VM with vhost-user as a scratch device. Resize the vhost-user scratch drive to have config change notifications and collect vhost-user metrics emitted by Firecracker for this test. Export the metrics to CloudWatch. We use a new file in performance directory for this test becuase: 1. Tests doesn't need to be ABfied so can't be part of test_block_ab and the Performance pipeline. 2. By running in nightly pipeline keeping the test in functional directory, there will be lot of other tests running in parallel resulting in noisy metrics. 3. Nightly pipeline runs performance tests in a decidated BK agent, with nothing else running on the host, and with no parallelism so it makes sense to move to performance directory but keep it out of AB tests. Signed-off-by: Sudan Landge <sudanl@amazon.com>
kalyazin
approved these changes
Nov 29, 2023
wearyzen
added
the
Status: Awaiting review
pb8o
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add a test to collect vhost-user metrics from Firecracker.
Reason
To monitor any regressions in vhost-user metrics over time.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] If a specific issue led to this PR, this PR closes the issue.[ ] Any required documentation changes (code and docs) are included in this PR.[ ] API changes follow the Runbook for Firecracker API changes.CHANGELOG.md.[ ] NewTODOs link to an issue.rust-vmm.