-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Refactor error propagation #4180
Merged
JonathanWoollett-Light
merged 2 commits into
firecracker-microvm:main
from
JonathanWoollett-Light:error-refactor
Oct 20, 2023
Merged
fix: Refactor error propagation #4180
JonathanWoollett-Light
merged 2 commits into
firecracker-microvm:main
from
JonathanWoollett-Light:error-refactor
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4180 +/- ##
==========================================
- Coverage 83.02% 83.00% -0.03%
==========================================
Files 222 222
Lines 28635 28642 +7
==========================================
Hits 23775 23775
- Misses 4860 4867 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
71255eb
to
a85ab86
Compare
b507103
to
f2e35c5
Compare
f2e35c5
to
794ad3d
Compare
794ad3d
to
d36d038
Compare
wearyzen
reviewed
Oct 19, 2023
d36d038
to
53e94ae
Compare
wearyzen
reviewed
Oct 19, 2023
9b9eefd
to
53e94ae
Compare
Refactors error propagation to avoid logging and printing misleading error messages. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
53e94ae
to
21e4560
Compare
wearyzen
approved these changes
Oct 19, 2023
roypat
reviewed
Oct 20, 2023
roypat
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Refactors error propagation to avoid logging and printing misleading error messages.
Reason
#4176
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
CHANGELOG.md
.TODO
s link to an issue.rust-vmm
.