feat: Remove Running Firecracker start-up log

There is no clear value in the log and it introduces additional complexity.

Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>

Author: Jonathan Woollett-Light

src/firecracker/src/main.rs

@@ -93,7 +93,6 @@ fn main() -> ExitCode {
 fn main_exec() -> Result<(), MainError> {
     // Initialize the logger.
     LOGGER.init().map_err(MainError::SetLogger)?;
-    info!("Running Firecracker v{FIRECRACKER_VERSION}");
 
     register_signal_handlers().map_err(MainError::RegisterSignalHandlers)?;
 

src/logger/Cargo.toml

@@ -3,7 +3,6 @@ name = "logger"
 version = "0.1.0"
 authors = ["Amazon Firecracker team <firecracker-devel@amazon.com>"]
 edition = "2021"
-build = "../../build.rs"
 license = "Apache-2.0"
 
 [lib]

src/logger/src/logger.rs

@@ -22,8 +22,6 @@ const DEFAULT_LEVEL: log::LevelFilter = log::LevelFilter::Info;
 pub const DEFAULT_INSTANCE_ID: &str = "anonymous-instance";
 /// Instance id.
 pub static INSTANCE_ID: OnceLock<String> = OnceLock::new();
-/// Semver version of Firecracker.
-const FIRECRACKER_VERSION: &str = env!("FIRECRACKER_VERSION");
 
 /// The logger.
 ///
@@ -96,13 +94,6 @@ impl Logger {
             guard.filter.module = Some(module);
         }
 
-        // Ensure we drop the guard before attempting to log, otherwise this
-        // would deadlock.
-        drop(guard);
-        if target_changed {
-            log::info!("Running Firecracker v{FIRECRACKER_VERSION}");
-        }
-
         Ok(())
     }
 }

tests/framework/microvm.py

@@ -316,9 +316,7 @@ def _validate_api_response_times(self):
     def firecracker_version(self):
         """Return the version of the Firecracker executable."""
         _, stdout, _ = utils.run_cmd(f"{self._fc_binary_path} --version")
-        # The 1st line will be `Running Firecracker vX.Y.Z`
-        # The 2nd line will be the output from `--version`.
-        line = stdout.split("\n")[1]
+        line = stdout.partition("\n")[0]
         result = re.match(r"^Firecracker v(.+)", line)
         return result.group(1)
 
@@ -504,8 +502,6 @@ def spawn(
         # and leave 0.2 delay between them.
         if "no-api" not in self.jailer.extra_args:
             self._wait_create()
-        if self.log_file and log_level in ("Trace", "Debug", "Info"):
-            self.check_log_message("Running Firecracker")
 
     @retry(delay=0.2, tries=5)
     def _wait_create(self):

tests/integration_tests/functional/test_logging.py

@@ -235,12 +235,6 @@ def _test_log_config(microvm, log_level="Info", show_level=True, show_origin=Tru
 
     lines = microvm.log_data.splitlines()
 
-    # Check for `Running Firecracker` message.
-    configured_level_no = LOG_LEVELS.index(to_formal_log_level(log_level))
-    info_level_no = LOG_LEVELS.index("INFO")
-    if info_level_no <= configured_level_no:
-        assert "Running Firecracker" in lines[0]
-
     # Check format of messages
     for line in lines:
         check_log_message_format(line, microvm.id, log_level, show_level, show_origin)