Skip to content

Commit 80591e0

Browse files
committed
tests: drop unused static cpu_templates fixture
This fixture is not used anymore, as it is mostly superseded by cpu_template_any. Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
1 parent 54ae107 commit 80591e0

File tree

2 files changed

+7
-15
lines changed

2 files changed

+7
-15
lines changed

tests/conftest.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -292,13 +292,6 @@ def microvm_factory(request, record_property, results_dir):
292292
uvm_factory.kill()
293293

294294

295-
@pytest.fixture(params=static_cpu_templates_params())
296-
def cpu_template(request, record_property):
297-
"""Return all static CPU templates supported by the vendor."""
298-
record_property("static_cpu_template", request.param)
299-
return request.param
300-
301-
302295
@pytest.fixture(params=custom_cpu_templates_params())
303296
def custom_cpu_template(request, record_property):
304297
"""Return all dummy custom CPU templates supported by the vendor."""

tests/integration_tests/functional/test_cpu_features_x86_64.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -952,18 +952,16 @@ def check_enabled_features(test_microvm, cpu_template):
952952
)
953953

954954

955-
def test_c3_on_skylake_show_warning(uvm_plain, cpu_template):
955+
def test_c3_on_skylake_show_warning(uvm_plain, cpu_template_any):
956956
"""
957957
This test verifies that the warning message about MMIO stale data mitigation
958-
is displayed only on Intel Skylake with C3 template.
958+
is displayed only on Intel Skylake with static C3 template.
959959
"""
960960
uvm = uvm_plain
961961
uvm.spawn()
962-
uvm.basic_config(
963-
vcpu_count=2,
964-
mem_size_mib=256,
965-
cpu_template=cpu_template,
966-
)
962+
uvm.basic_config(vcpu_count=2, mem_size_mib=256)
963+
uvm.add_net_iface()
964+
uvm.set_cpu_template(cpu_template_any)
967965
uvm.start()
968966

969967
message = (
@@ -972,7 +970,8 @@ def test_c3_on_skylake_show_warning(uvm_plain, cpu_template):
972970
"does not apply the mitigation against MMIO stale data "
973971
"vulnerability."
974972
)
975-
if uvm.cpu_template_name == "c3" and global_props.cpu_codename == "INTEL_SKYLAKE":
973+
974+
if cpu_template_any == "C3" and global_props.cpu_codename == "INTEL_SKYLAKE":
976975
assert message in uvm.log_data
977976
else:
978977
assert message not in uvm.log_data

0 commit comments

Comments
 (0)